You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Jan Høydahl (JIRA)" <ji...@apache.org> on 2016/08/02 14:01:20 UTC

[jira] [Resolved] (SOLR-9368) FileDictionaryFactory does not treat lines beginning with '#' as comments

     [ https://issues.apache.org/jira/browse/SOLR-9368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jan Høydahl resolved SOLR-9368.
-------------------------------
    Resolution: Not A Bug

Resolving as not a bug. I updated the text in https://cwiki.apache.org/confluence/display/solr/Suggester#Suggester-FileDictionaryFactory to be in line with the actual code, also removing the claim that blank lines are allowed. I also updated the example, replacing literal \t with a tab character.

> FileDictionaryFactory does not treat lines beginning with '#' as comments
> -------------------------------------------------------------------------
>
>                 Key: SOLR-9368
>                 URL: https://issues.apache.org/jira/browse/SOLR-9368
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: Suggester
>    Affects Versions: 6.1
>            Reporter: John Iacona
>            Priority: Minor
>
> The documentation for FileDictionaryFactory states that "Blank lines and lines that start with a '#' are ignored". This is not the case. When loading a dictionary file with '#' prefixed lines, they just get interpreted as terms and show up in suggestion results. 
> This causes additional confusion when trying to use payloads. As stated in https://lucene.apache.org/core/6_1_0/suggest/org/apache/lucene/search/suggest/FileDictionary.html : "In order to have payload enabled, the first entry has to have a payload". However, if you happen to have a "comment" as the first line in a dictionary file (that doesn't happen to have two instances of the fieldDelimiter in it...), payloads are disabled.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org