[GitHub] [cloudstack] nvazquez commented on a change in pull request #4062: [VMware] Cannot migrate VM on PVLAN shared network

[GitBox <gi...@apache.org>]

nvazquez commented on a change in pull request #4062:
URL: https://github.com/apache/cloudstack/pull/4062#discussion_r425935527



##########
File path: server/src/main/java/com/cloud/network/element/VirtualRouterElement.java
##########
@@ -1223,8 +1223,7 @@ public boolean prepareMigration(final NicProfile nic, final Network network, fin
             }
         } else if (vm.getType() == VirtualMachine.Type.User) {
             assert vm instanceof UserVmVO;
-            final UserVmVO userVm = (UserVmVO) vm.getVirtualMachine();

Review comment:
       Thanks @sureshanaparti. I have not observed errors in those other castings but will be nice to solve the problem instead of the workaround I'm proposing in this fix, will take a look into that




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org