You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@samza.apache.org by Jagadish Venkatraman <ja...@gmail.com> on 2016/08/05 01:31:31 UTC

Review Request 50828: SAMZA-994 Fix StreamAppender to work with the refactored Job Coordinator

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50828/
-----------------------------------------------------------

Review request for samza.


Repository: samza


Description
-------

The Stream Appender recognizes that it's running in the app-master by checking for the presence of the string "application-master" in the container.id environment variable. However, the refactoring changed the AM to Job Coordinator. The Stream Appender must be updated to look for the "job-coordinator" in the container.id instead of "application-master".

In the absence of this change, the stream appender in the AM will crash.


Diffs
-----

  samza-log4j/src/main/java/org/apache/samza/logging/log4j/StreamAppender.java ca4eb7fa890fe8d7d8f6e2f59351b352222c0e41 
  samza-log4j/src/test/java/org/apache/samza/logging/log4j/TestStreamAppender.java e2e17a06159a35234270f342e8ae1c81031d971b 

Diff: https://reviews.apache.org/r/50828/diff/


Testing
-------

Updated unit tests and tested with a sample job.


Thanks,

Jagadish Venkatraman