You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2020/02/27 18:33:25 UTC
[GitHub] [cordova-plugin-inappbrowser] PDLMobileApps opened a new pull
request #634: (android) Added option to turn on/off fullscreen mode in
Android
PDLMobileApps opened a new pull request #634: (android) Added option to turn on/off fullscreen mode in Android
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/634
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
Android
### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
Resolves #598
<!-- If it fixes an open issue, please link to the issue here. -->
Link to the issue: https://github.com/apache/cordova-plugin-inappbrowser/issues/598
### Description
<!-- Describe your changes in detail -->
This PR adds a new Android option to fix bug #598
The new option (fullscreen - yes/no) enables/disables the fullscreen WebView on Android. The default value is no.
### Testing
<!-- Please describe in detail how you tested your changes. -->
Testing was done manually as I am not sure on how to automate it.
1. Created a new Cordova test app using cordova-plugin-inappbrowser.
2. Executed:
`cordova.InAppBrowser.open(url, "_blank", "");`
and verified the WebView is not opening in fullscreen mode.
3. Executed:
`cordova.InAppBrowser.open(url, "_blank", "fullscreen=no");`
and verified the WebView is not opening in fullscreen mode.
4. Executed:
`cordova.InAppBrowser.open(url, "_blank", "fullscreen=yes");`
and verified the WebView is opening in fullscreen mode.
### Checklist
- [x] I've run the tests to see all new and existing tests pass
- [ ] I added automated test coverage as appropriate for this change
- [x] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
- [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
- [x] I've updated the documentation if necessary
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] timbru31 commented on issue #634:
(android) Added option to turn on/off fullscreen mode in Android
Posted by GitBox <gi...@apache.org>.
timbru31 commented on issue #634: (android) Added option to turn on/off fullscreen mode in Android
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/634#issuecomment-602728682
Can you please remove the plugins and platforms folder and re-add the Android platform
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] mosabab commented on issue #634:
(android) Added option to turn on/off fullscreen mode in Android
Posted by GitBox <gi...@apache.org>.
mosabab commented on issue #634: (android) Added option to turn on/off fullscreen mode in Android
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/634#issuecomment-606694530
@timbru31
How we can make inappbrowser statusbar take the effects from the settings ?
What i mean:
The main webview status bar using red color im the main app webview.
But after inappbrowser opened, the statusbar became in black background color.
Regards
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] timbru31 merged pull request #634:
(android) Added option to turn on/off fullscreen mode in Android
Posted by GitBox <gi...@apache.org>.
timbru31 merged pull request #634: (android) Added option to turn on/off fullscreen mode in Android
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/634
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] mosabab commented on issue #634:
(android) Added option to turn on/off fullscreen mode in Android
Posted by GitBox <gi...@apache.org>.
mosabab commented on issue #634: (android) Added option to turn on/off fullscreen mode in Android
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/634#issuecomment-603234108
> Did it work for you? @mosabab
Thanks for asking, and sorry for late response.
EXACTLY: THANKS AGAIN
WORK AS EXPECTED.
What to do:
1- I remove the platform. 2- delete plugin folder 3- delete package.json file 4- add platform again.
Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] PDLMobileApps commented on a change
in pull request #634: (android) Added option to turn on/off fullscreen mode
in Android
Posted by GitBox <gi...@apache.org>.
PDLMobileApps commented on a change in pull request #634: (android) Added option to turn on/off fullscreen mode in Android
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/634#discussion_r393903105
##########
File path: src/android/InAppBrowser.java
##########
@@ -147,6 +148,7 @@ Licensed to the Apache Software Foundation (ASF) under one
private boolean showFooter = false;
private String footerColor = "";
private String beforeload = "";
+ private boolean fullscreen = false;
Review comment:
I agree. I set it to false as the web view should have never been opened in full screen in the first place (unless it's a game). Anyway, I understand the backward compatibility requirement.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] mosabab commented on issue #634:
(android) Added option to turn on/off fullscreen mode in Android
Posted by GitBox <gi...@apache.org>.
mosabab commented on issue #634: (android) Added option to turn on/off fullscreen mode in Android
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/634#issuecomment-602728233
I will check again
Anyway
Thank you for help
Regards
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] PDLMobileApps commented on a change
in pull request #634: (android) Added option to turn on/off fullscreen mode
in Android
Posted by GitBox <gi...@apache.org>.
PDLMobileApps commented on a change in pull request #634: (android) Added option to turn on/off fullscreen mode in Android
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/634#discussion_r393913460
##########
File path: package.json
##########
@@ -1,6 +1,6 @@
{
"name": "cordova-plugin-inappbrowser",
- "version": "3.2.1-dev",
+ "version": "3.2.2-dev",
Review comment:
I reverted all version changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] mosabab edited a comment on issue
#634: (android) Added option to turn on/off fullscreen mode in Android
Posted by GitBox <gi...@apache.org>.
mosabab edited a comment on issue #634: (android) Added option to turn on/off fullscreen mode in Android
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/634#issuecomment-602708465
Yes i install the plugin from forked repo as you mentioned
But the problem still in full screen. (Status bar hidden)
Did you see the inappbrowser with status bar (not in full screen)
If yes
Could you please attach screenshot
Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] mosabab commented on issue #634:
(android) Added option to turn on/off fullscreen mode in Android
Posted by GitBox <gi...@apache.org>.
mosabab commented on issue #634: (android) Added option to turn on/off fullscreen mode in Android
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/634#issuecomment-602725067
I set the option fullscreen to no
But this not work for me, the inappbrowser still in full screen even if i set to no
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] mosabab commented on issue #634:
(android) Added option to turn on/off fullscreen mode in Android
Posted by GitBox <gi...@apache.org>.
mosabab commented on issue #634: (android) Added option to turn on/off fullscreen mode in Android
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/634#issuecomment-602730577
I will try to remove platform and plugins folders and i will tell you if it work
Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] mosabab commented on issue #634:
(android) Added option to turn on/off fullscreen mode in Android
Posted by GitBox <gi...@apache.org>.
mosabab commented on issue #634: (android) Added option to turn on/off fullscreen mode in Android
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/634#issuecomment-602665101
> Quickly tested this with my Android device, changes work as expected.
Hello,
I test this pull from my android studio emulator , but inappbrowser still in full screen mode !!!
I am using `fullscreen=no`
could you please tell me how to check this to make inappbrowser without full screen ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] timbru31 commented on a change in
pull request #634: (android) Added option to turn on/off fullscreen mode in
Android
Posted by GitBox <gi...@apache.org>.
timbru31 commented on a change in pull request #634: (android) Added option to turn on/off fullscreen mode in Android
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/634#discussion_r393932004
##########
File path: src/android/InAppBrowser.java
##########
@@ -147,6 +148,7 @@ Licensed to the Apache Software Foundation (ASF) under one
private boolean showFooter = false;
private String footerColor = "";
private String beforeload = "";
+ private boolean fullscreen = false;
Review comment:
@breautek @NiklasMerz - what's your opinion on this? It seems v3.1.0 accidentally sneaked in this breaking change (see, e.g. https://github.com/apache/cordova-plugin-inappbrowser/issues/598#issuecomment-572597994)
Should we (a) restore v3.0.0 behavior or (b) follow semver and make it configurable in a minor release?
The change to always full screen is now live since Jun 28, 2019, so nearly two years.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] timbru31 commented on issue #634:
(android) Added option to turn on/off fullscreen mode in Android
Posted by GitBox <gi...@apache.org>.
timbru31 commented on issue #634: (android) Added option to turn on/off fullscreen mode in Android
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/634#issuecomment-603222768
Did it work for you? @mosabab
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] timbru31 commented on issue #634:
(android) Added option to turn on/off fullscreen mode in Android
Posted by GitBox <gi...@apache.org>.
timbru31 commented on issue #634: (android) Added option to turn on/off fullscreen mode in Android
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/634#issuecomment-602705928
Yeah you've need to install the plugin from the forked repo:
`cordova plugin add https://github.com/PDLMobileApps/cordova-plugin-inappbrowser.git\#bug-598`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] mosabab removed a comment on issue
#634: (android) Added option to turn on/off fullscreen mode in Android
Posted by GitBox <gi...@apache.org>.
mosabab removed a comment on issue #634: (android) Added option to turn on/off fullscreen mode in Android
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/634#issuecomment-606694530
@timbru31
How we can make inappbrowser statusbar take the effects from the settings ?
What i mean:
The main webview status bar using red color im the main app webview.
But after inappbrowser opened, the statusbar became in black background color.
Regards
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] timbru31 commented on issue #634:
(android) Added option to turn on/off fullscreen mode in Android
Posted by GitBox <gi...@apache.org>.
timbru31 commented on issue #634: (android) Added option to turn on/off fullscreen mode in Android
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/634#issuecomment-603236627
Great, thanks for testing this. PR merged, thanks @PDLMobileApps for your contribution!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] mosabab commented on issue #634:
(android) Added option to turn on/off fullscreen mode in Android
Posted by GitBox <gi...@apache.org>.
mosabab commented on issue #634: (android) Added option to turn on/off fullscreen mode in Android
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/634#issuecomment-602698850
@timbru31 i am using the master version of inappbrowser plugin and i fork it and modify android code to using this for fullscreen
And in inappbrowser settings i set fullscreen=no
But inappbrowser still in full screen mode
(The master version of inappbrowser still not merged with this pull)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] mosabab commented on issue #634:
(android) Added option to turn on/off fullscreen mode in Android
Posted by GitBox <gi...@apache.org>.
mosabab commented on issue #634: (android) Added option to turn on/off fullscreen mode in Android
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/634#issuecomment-602708465
Yes i install the plugin from forked repo as you mentioned
But the problem still in full screen.
Did you see the inappbrowser with status bar (not in full screen)
If yes
Could you please attach screenshot
Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] timbru31 edited a comment on issue
#634: (android) Added option to turn on/off fullscreen mode in Android
Posted by GitBox <gi...@apache.org>.
timbru31 edited a comment on issue #634: (android) Added option to turn on/off fullscreen mode in Android
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/634#issuecomment-602677132
Exactly like you, with the `fullscreen=no` option. Can you double check that your project uses the git branch and not the npm release?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] timbru31 commented on a change in
pull request #634: (android) Added option to turn on/off fullscreen mode in
Android
Posted by GitBox <gi...@apache.org>.
timbru31 commented on a change in pull request #634: (android) Added option to turn on/off fullscreen mode in Android
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/634#discussion_r393932004
##########
File path: src/android/InAppBrowser.java
##########
@@ -147,6 +148,7 @@ Licensed to the Apache Software Foundation (ASF) under one
private boolean showFooter = false;
private String footerColor = "";
private String beforeload = "";
+ private boolean fullscreen = false;
Review comment:
@breautek @NiklasMerz - what's your opinion on this? It seems v3.1.0 accidentally sneaked in this breaking change (see, e.g. https://github.com/apache/cordova-plugin-inappbrowser/issues/598#issuecomment-572597994)
Should we (a) restore v3.0.0 behavior or (b) follow semver and make it configurable in a minor release?
The change to always full screen is now live since Jun 28, 2019, so nearly two years.
Personally I'd vote for b)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] mosabab edited a comment on issue
#634: (android) Added option to turn on/off fullscreen mode in Android
Posted by GitBox <gi...@apache.org>.
mosabab edited a comment on issue #634: (android) Added option to turn on/off fullscreen mode in Android
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/634#issuecomment-602708465
Yes i install the plugin from forked repo as you mentioned
But the problem still in full screen. (Status bar hidde)
Did you see the inappbrowser with status bar (not in full screen)
If yes
Could you please attach screenshot
Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] timbru31 commented on issue #634:
(android) Added option to turn on/off fullscreen mode in Android
Posted by GitBox <gi...@apache.org>.
timbru31 commented on issue #634: (android) Added option to turn on/off fullscreen mode in Android
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/634#issuecomment-602677132
Exactly like you, with the `fullscreen=no` option. Can you double check that your project uses the git master and not the npm release?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] timbru31 commented on issue #634:
(android) Added option to turn on/off fullscreen mode in Android
Posted by GitBox <gi...@apache.org>.
timbru31 commented on issue #634: (android) Added option to turn on/off fullscreen mode in Android
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/634#issuecomment-602724672
Sure:
`cordova.InAppBrowser.open("https://google.com", "_blank")`

`cordova.InAppBrowser.open("https://google.com", "_blank", "fullscreen=no")`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] timbru31 commented on a change in
pull request #634: (android) Added option to turn on/off fullscreen mode in
Android
Posted by GitBox <gi...@apache.org>.
timbru31 commented on a change in pull request #634: (android) Added option to turn on/off fullscreen mode in Android
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/634#discussion_r393786989
##########
File path: src/android/InAppBrowser.java
##########
@@ -147,6 +148,7 @@ Licensed to the Apache Software Foundation (ASF) under one
private boolean showFooter = false;
private String footerColor = "";
private String beforeload = "";
+ private boolean fullscreen = false;
Review comment:
See above, the default need to be true in order to avoid a breaking change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] breautek commented on a change in
pull request #634: (android) Added option to turn on/off fullscreen mode in
Android
Posted by GitBox <gi...@apache.org>.
breautek commented on a change in pull request #634: (android) Added option to turn on/off fullscreen mode in Android
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/634#discussion_r393941052
##########
File path: src/android/InAppBrowser.java
##########
@@ -147,6 +148,7 @@ Licensed to the Apache Software Foundation (ASF) under one
private boolean showFooter = false;
private String footerColor = "";
private String beforeload = "";
+ private boolean fullscreen = false;
Review comment:
Not very knowledgeable with the in-app-browser but unless if there is a very good reason why it should be hard-coded (which I don't think there is any?), I think we should be non-opinionated and let it be configurable.
Normally I'd also vote to revert the default as well, but if it's been live for nearly two years, I think it's smarter to just leave the "default" as `true`. I think if we change it to `false` now, then we would have to treat this PR as a breaking change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] timbru31 commented on a change in
pull request #634: (android) Added option to turn on/off fullscreen mode in
Android
Posted by GitBox <gi...@apache.org>.
timbru31 commented on a change in pull request #634: (android) Added option to turn on/off fullscreen mode in Android
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/634#discussion_r393601131
##########
File path: package.json
##########
@@ -1,6 +1,6 @@
{
"name": "cordova-plugin-inappbrowser",
- "version": "3.2.1-dev",
+ "version": "3.2.2-dev",
Review comment:
Please revert the version changes again.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org