You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by manishamde <gi...@git.apache.org> on 2014/12/01 03:56:16 UTC

[GitHub] spark pull request: [SPARK-4580] [SPARK-4610] [mllib] Documentatio...

Github user manishamde commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3461#discussion_r21067657
  
    --- Diff: docs/mllib-decision-tree.md ---
    @@ -103,36 +106,73 @@ and the resulting `$M-1$` split candidates are considered.
     
     ### Stopping rule
     
    -The recursive tree construction is stopped at a node when one of the two conditions is met:
    +The recursive tree construction is stopped at a node when one of the following conditions is met:
     
     1. The node depth is equal to the `maxDepth` training parameter.
    -2. No split candidate leads to an information gain at the node.
    +2. No split candidate leads to an information gain greater than `minInfoGain`.
    +3. No split candidate produces child nodes which each have at least `minInstancesPerNode` training instances.
    +
    +## Usage tips
    +
    +We include a few guidelines for using decision trees by discussing the various parameters.
    +There are many parameters, put in order here with the most imporant first.  New users should mainly consider the "Problem specification parameters" section below and the `maxDepth` parameter.
    --- End diff --
    
    Rephrase? The parameters are listed here in descending order of importance.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org