You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "awayings (GitHub)" <gi...@apache.org> on 2019/02/20 06:45:23 UTC
[GitHub] [incubator-dubbo] awayings opened pull request #3516: dubbo-parent是头文件不包含依赖。替换成dubbo, 同时增加zk连接的依赖。
## What is the purpose of the change
文档不正确，运行时会缺少依赖
## Brief changelog
增加dubbo的pom文件。zookeeper/curator-framework的依赖。因为dubbo-dependencies-bom当中声明curator-framework时去除了zookeeper的版本，所以外部还需要额外机上zookeeper的依赖包。
## Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
- [x] Make sure there is a [GITHUB_issue](https://github.com/apache/incubator-dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/incubator-dubbo/tree/master/dubbo-test).
- [ ] Run `mvn clean install -DskipTests=false` & `mvn clean test-compile failsafe:integration-test` to make sure unit-test and integration-test pass.
- [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/incubator-dubbo/wiki/Software-donation-guide).
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3516 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] beiwei30 commented on issue #3516: dubbo-parent是头文件不包含依赖。替换成dubbo, 同时增加zk连接的依赖。
Posted by "beiwei30 (GitHub)" <gi...@apache.org>.
merge it in for now, since it helps user to add appropriated zk dependency, again, we will refresh README when we release 2.7.1
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3516 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] beiwei30 closed pull request #3516: dubbo-parent是头文件不包含依赖。替换成dubbo, 同时增加zk连接的依赖。
Posted by "beiwei30 (GitHub)" <gi...@apache.org>.
[ pull request closed by beiwei30 ]
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3516 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] codecov-io commented on issue #3516: dubbo-parent是头文件不包含依赖。替换成dubbo, 同时增加zk连接的依赖。
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3516?src=pr&el=h1) Report
> Merging [#3516](https://codecov.io/gh/apache/incubator-dubbo/pull/3516?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/f415fda0347e4ea6f75a1e62d05b8d560b051670?src=pr&el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-dubbo/pull/3516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3516 +/- ##
============================================
+ Coverage 64.08% 64.09% +0.01%
Complexity 71 71
============================================
Files 664 664
Lines 28618 28618
Branches 4771 4771
============================================
+ Hits 18341 18344 +3
+ Misses 8055 8050 -5
- Partials 2222 2224 +2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/3516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../dubbo/remoting/transport/netty4/NettyChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3516/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHk0L05ldHR5Q2hhbm5lbC5qYXZh) | `61.17% <0%> (-4.71%)` | `0% <0%> (ø)` | |
| [...pache/dubbo/registry/support/AbstractRegistry.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3516/diff?src=pr&el=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9zdXBwb3J0L0Fic3RyYWN0UmVnaXN0cnkuamF2YQ==) | `80.31% <0%> (+1.18%)` | `0% <0%> (ø)` | :arrow_down: |
| [.../apache/dubbo/remoting/transport/AbstractPeer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3516/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQWJzdHJhY3RQZWVyLmphdmE=) | `63.04% <0%> (+4.34%)` | `0% <0%> (ø)` | :arrow_down: |
| [...onfig/spring/extension/SpringExtensionFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3516/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvZXh0ZW5zaW9uL1NwcmluZ0V4dGVuc2lvbkZhY3RvcnkuamF2YQ==) | `85.36% <0%> (+4.87%)` | `0% <0%> (ø)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3516?src=pr&el=footer). Last update [f415fda...862c5e2](https://codecov.io/gh/apache/incubator-dubbo/pull/3516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3516 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] beiwei30 commented on issue #3516: dubbo-parent是头文件不包含依赖。替换成dubbo, 同时增加zk连接的依赖。
Posted by "beiwei30 (GitHub)" <gi...@apache.org>.
we will refresh README when we release 2.7.1, stay tuned.
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3516 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] beiwei30 closed pull request #3516: dubbo-parent是头文件不包含依赖。替换成dubbo, 同时增加zk连接的依赖。
Posted by "beiwei30 (GitHub)" <gi...@apache.org>.
[ pull request closed by beiwei30 ]
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3516 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org