You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2020/07/07 07:44:38 UTC
[GitHub] [hive] klcopp opened a new pull request #1216: HIVE-23760: Upgrading to Kafka 2.5 Clients
klcopp opened a new pull request #1216:
URL: https://github.com/apache/hive/pull/1216
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] klcopp merged pull request #1216: HIVE-23760: Upgrading to Kafka 2.5 Clients
Posted by GitBox <gi...@apache.org>.
klcopp merged pull request #1216:
URL: https://github.com/apache/hive/pull/1216
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pvary commented on a change in pull request #1216: HIVE-23760: Upgrading to Kafka 2.5 Clients
Posted by GitBox <gi...@apache.org>.
pvary commented on a change in pull request #1216:
URL: https://github.com/apache/hive/pull/1216#discussion_r452189602
##########
File path: itests/qtest-druid/src/main/java/org/apache/hive/kafka/SingleNodeKafkaCluster.java
##########
@@ -175,24 +165,18 @@ public void createTopicWithData(String topic, List<byte []> events) {
}
}
- public void createTopic(String topic) {
- int sessionTimeoutMs = 1000;
- ZkClient zkClient = new ZkClient(
- this.zkString, sessionTimeoutMs, sessionTimeoutMs,
- ZKStringSerializer$.MODULE$
- );
- ZkUtils zkUtils = new ZkUtils(zkClient, new ZkConnection(zkString, sessionTimeoutMs), false);
+ private void createTopic(String topic) {
+ Properties properties = new Properties();
+ properties.setProperty("bootstrap.servers", "localhost:9092");
+ properties.setProperty("key.deserializer", "org.apache.kafka.common.serialization.StringDeserializer");
+ properties.setProperty("value.deserializer","org.apache.kafka.common.serialization.StringDeserializer");
Review comment:
nit-nit: space? :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pvary commented on a change in pull request #1216: HIVE-23760: Upgrading to Kafka 2.5 Clients
Posted by GitBox <gi...@apache.org>.
pvary commented on a change in pull request #1216:
URL: https://github.com/apache/hive/pull/1216#discussion_r452031376
##########
File path: itests/qtest-druid/src/main/java/org/apache/hive/kafka/SingleNodeKafkaCluster.java
##########
@@ -175,24 +165,20 @@ public void createTopicWithData(String topic, List<byte []> events) {
}
}
- public void createTopic(String topic) {
- int sessionTimeoutMs = 1000;
- ZkClient zkClient = new ZkClient(
- this.zkString, sessionTimeoutMs, sessionTimeoutMs,
- ZKStringSerializer$.MODULE$
- );
- ZkUtils zkUtils = new ZkUtils(zkClient, new ZkConnection(zkString, sessionTimeoutMs), false);
+ private void createTopic(String topic) {
+ Properties properties = new Properties();
+ properties.setProperty("bootstrap.servers", "localhost:9092");
+ properties.setProperty("key.deserializer", "org.apache.kafka.common.serialization"
Review comment:
Maybe optimizer fixes this automatically, but could we just break the line at the ',' instead of adding a new concatenation?
##########
File path: itests/qtest-druid/src/main/java/org/apache/hive/kafka/SingleNodeKafkaCluster.java
##########
@@ -175,24 +165,20 @@ public void createTopicWithData(String topic, List<byte []> events) {
}
}
- public void createTopic(String topic) {
- int sessionTimeoutMs = 1000;
- ZkClient zkClient = new ZkClient(
- this.zkString, sessionTimeoutMs, sessionTimeoutMs,
- ZKStringSerializer$.MODULE$
- );
- ZkUtils zkUtils = new ZkUtils(zkClient, new ZkConnection(zkString, sessionTimeoutMs), false);
+ private void createTopic(String topic) {
+ Properties properties = new Properties();
+ properties.setProperty("bootstrap.servers", "localhost:9092");
+ properties.setProperty("key.deserializer", "org.apache.kafka.common.serialization"
+ + ".StringDeserializer");
+ properties.setProperty("value.deserializer","org.apache.kafka.common.serialization"
Review comment:
Maybe optimizer fixes this automatically, but could we just break the line at the ',' instead of adding a new concatenation?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] klcopp commented on pull request #1216: HIVE-23760: Upgrading to Kafka 2.5 Clients
Posted by GitBox <gi...@apache.org>.
klcopp commented on pull request #1216:
URL: https://github.com/apache/hive/pull/1216#issuecomment-655578545
@pvary, would you mind taking a look?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org