You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "Roiocam (via GitHub)" <gi...@apache.org> on 2025/11/26 16:17:21 UTC

[PR] feat: optimized event tags table writes [pekko-persistence-jdbc]

Roiocam opened a new pull request, #386:
URL: https://github.com/apache/pekko-persistence-jdbc/pull/386

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] feat: optimized event tags table writes [pekko-persistence-jdbc]

Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #386:
URL: https://github.com/apache/pekko-persistence-jdbc/pull/386#discussion_r2565675605


##########
core/src/main/mima-filters/2.0.x.backwards.excludes/event-tags-insert-optimized.excludes:
##########
@@ -0,0 +1,10 @@
+ProblemFilters.exclude[IncompatibleSignatureProblem]("org.apache.pekko.persistence.jdbc.journal.dao.JournalTables#EventTags.eventId")

Review Comment:
   Could you add an Apache source file header? The standard header as opposed to the Pekko one that mentions Akka.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] feat: optimized event tags table writes [pekko-persistence-jdbc]

Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin merged PR #386:
URL: https://github.com/apache/pekko-persistence-jdbc/pull/386


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] feat: optimized event tags table writes [pekko-persistence-jdbc]

Posted by "Roiocam (via GitHub)" <gi...@apache.org>.
Roiocam commented on PR #386:
URL: https://github.com/apache/pekko-persistence-jdbc/pull/386#issuecomment-4350045319

   @pjfanning @He-Pin  I have fix the CI fissue, place take a look.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] feat: optimized event tags table writes [pekko-persistence-jdbc]

Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #386:
URL: https://github.com/apache/pekko-persistence-jdbc/pull/386#issuecomment-3589169555

   @Roiocam I took your fixes for the typos and applied then separately. I rebased your PR if that is ok.
   
   I have a question about the migration sql files. They seem useful but would I be right in saying that users will need to run them themselves or are they automatically applied? The reason I ask is that I plan to push on the 1.2.0 release and there are db schema changes in it and I'm wondering if I should add migration scripts to 1.2.0. So far, I just document in the release notes that there are changes and that users can apply them for themselves. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org