[jira] Commented: (CAMEL-1524) camel-irc URI parsing is flawed

["Darren Davison (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/activemq/browse/CAMEL-1524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=51268#action_51268 ] 

Darren Davison commented on CAMEL-1524:
---------------------------------------

it was actually Stan's patch :)  But thanks for applying it.

> camel-irc URI parsing is flawed
> -------------------------------
>
>                 Key: CAMEL-1524
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1524
>             Project: Apache Camel
>          Issue Type: Bug
>          Components: documentation
>    Affects Versions: 1.6.0
>            Reporter: Darren Davison
>            Assignee: Hadrian Zbarcea
>            Priority: Trivial
>             Fix For: 2.0.0, 1.6.1
>
>         Attachments: patch.txt
>
>
> the example URI for the camel-irc component (see http://camel.apache.org/irc.html) does not work.  Further, the current URI parsing code is flawed and subject to NPE's.
> In IrcConfiguration.configure(URI uri) (see https://svn.apache.org/repos/asf/camel/branches/camel-1.x/components/camel-irc/src/main/java/org/apache/camel/component/irc/IrcConfiguration.java) the code attempts to parse a channel name as a path.  Because the '#' char is a fragment marker in a URI, the path (in the documented example) is zero length.
> The following URI works with the current code implementation (note the required '//' and html-escaped '#' char):
> {code}irc://nick@server.org/%23channel{code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.