You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "florin-akermann (via GitHub)" <gi...@apache.org> on 2023/08/10 19:59:43 UTC
[GitHub] [kafka] florin-akermann opened a new pull request, #14187: KAFKA-13197: fix GlobalKTable join/left-join semantics documentation.
florin-akermann opened a new pull request, #14187:
URL: https://github.com/apache/kafka/pull/14187
The documentation for join/left-join Kstream-GlobalKtable is out dated: The left hand side key may be null.
Note that the second statement mentioned in the Jira https://issues.apache.org/jira/browse/KAFKA-13197 is no longer present.
Note: The constraint that KeyValueMapper cannot return null for left joins or else the record gets dropped will be relaxed as part of https://cwiki.apache.org/confluence/display/KAFKA/KIP-962%3A+Relax+non-null+key+requirement+in+Kafka+Streams
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mjsax commented on pull request #14187: KAFKA-13197: fix GlobalKTable join/left-join semantics documentation.
Posted by "mjsax (via GitHub)" <gi...@apache.org>.
mjsax commented on PR #14187:
URL: https://github.com/apache/kafka/pull/14187#issuecomment-1675218688
Thanks for the PR! Merged to ` trunk` and cherry-picked to `3.5` branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mjsax commented on a diff in pull request #14187: KAFKA-13197: fix GlobalKTable join/left-join semantics documentation.
Posted by "mjsax (via GitHub)" <gi...@apache.org>.
mjsax commented on code in PR #14187:
URL: https://github.com/apache/kafka/pull/14187#discussion_r1290758646
##########
streams/src/main/java/org/apache/kafka/streams/kstream/KStream.java:
##########
@@ -2805,7 +2805,7 @@ <VT, VR> KStream<K, VR> leftJoin(final KTable<K, VT> table,
* For each {@code KStream} record that finds a corresponding record in {@link GlobalKTable} the provided
* {@link ValueJoiner} will be called to compute a value (with arbitrary type) for the result record.
* The key of the result record is the same as the key of this {@code KStream}.
- * If a {@code KStream} input record key or value is {@code null} the record will not be included in the join
+ * If a {@code KStream} input value is {@code null} the record will not be included in the join
* operation and thus no output record will be added to the resulting {@code KStream}.
* If {@code keyValueMapper} returns {@code null} implying no match exists, no output record will be added to the
* resulting {@code KStream}.
Review Comment:
Should we merge both sentences:
```
If a {@code KStream} input record key or value is {@code null} the record will not be included in the join
* If a {@code KStream} input value is {@code null} the record will not be included in the join
* operation and thus no output record will be added to the resulting {@code KStream}.
* If {@code keyValueMapper} returns {@code null} implying no match exists, no output record will be added to the
* resulting {@code KStream}.
```
Into:
```
* If a {@code KStream} input value is {@code null} or if {@code keyValueMapper} returns {@code null} the record
* will not be included in the join operation and thus no output record will be added to the resulting {@code KStream}.
```
Same below? (Note: for left-join the JavaDocs about `null` returned from `keyValueMapper` seem to be wrong, too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] florin-akermann commented on a diff in pull request #14187: KAFKA-13197: fix GlobalKTable join/left-join semantics documentation.
Posted by "florin-akermann (via GitHub)" <gi...@apache.org>.
florin-akermann commented on code in PR #14187:
URL: https://github.com/apache/kafka/pull/14187#discussion_r1291165997
##########
streams/src/main/java/org/apache/kafka/streams/kstream/KStream.java:
##########
@@ -2805,7 +2805,7 @@ <VT, VR> KStream<K, VR> leftJoin(final KTable<K, VT> table,
* For each {@code KStream} record that finds a corresponding record in {@link GlobalKTable} the provided
* {@link ValueJoiner} will be called to compute a value (with arbitrary type) for the result record.
* The key of the result record is the same as the key of this {@code KStream}.
- * If a {@code KStream} input record key or value is {@code null} the record will not be included in the join
+ * If a {@code KStream} input value is {@code null} the record will not be included in the join
* operation and thus no output record will be added to the resulting {@code KStream}.
* If {@code keyValueMapper} returns {@code null} implying no match exists, no output record will be added to the
* resulting {@code KStream}.
Review Comment:
I agree, it is more concise.
Regarding the left-join - yes, I adjusted that one too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mjsax merged pull request #14187: KAFKA-13197: fix GlobalKTable join/left-join semantics documentation.
Posted by "mjsax (via GitHub)" <gi...@apache.org>.
mjsax merged PR #14187:
URL: https://github.com/apache/kafka/pull/14187
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org