You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/02/19 21:26:42 UTC

[GitHub] [spark] MaxGekk commented on a change in pull request #31596: [SPARK-34475][SQL] Rename logical nodes of v2 `ALTER` commands

MaxGekk commented on a change in pull request #31596:
URL: https://github.com/apache/spark/pull/31596#discussion_r579484987



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/command/PlanResolutionSuite.scala
##########
@@ -808,11 +808,11 @@ class PlanResolutionSuite extends AnalysisTest {
 
     // For non-existing tables, we convert it to v2 command with `UnresolvedV2Table`
     parsed4 match {
-      case AlterTableSetProperties(_: UnresolvedTable, _) => // OK
+      case SetTableProperties(_: UnresolvedTable, _) => // OK
       case _ => fail("Expect AlterTableSetProperties, but got:\n" + parsed4.treeString)

Review comment:
       @imback82 Thank you. Maybe, we should replace it by `${SetTableProperties.getClass.getName}` to easily find it in IDE.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org