You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "sshiv012 (via GitHub)" <gi...@apache.org> on 2026/09/30 05:14:24 UTC
[PR] feat(computing-unit-managing-service): say how to free a slot when the CU quota is reached [texera]
sshiv012 opened a new pull request, #8772:
URL: https://github.com/apache/texera/pull/8772
### What changes were proposed in this PR?
When a user hits the computing unit limit, the error only said "You may only have N computing-unit(s) running at the same time". It now adds what to do: "Reuse one of your running computing units, or terminate one you no longer need."
### Any related issues, documentation, discussions?
Part of #8736. Split out of #8737.
### How was this PR tested?
Updated `ComputingUnitManagingServiceExceptionSpec`. `ComputingUnitManagingService/testOnly ...ComputingUnitManagingServiceExceptionSpec` and scalafmtCheck pass. There's no screenshot because this dialog only appears on a Kubernetes deployment, and I tested on a local install.
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Opus 5.5)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(computing-unit-managing-service): say how to free a slot when the CU quota is reached [texera]
Posted by "Xiao-zhen-Liu (via GitHub)" <gi...@apache.org>.
Xiao-zhen-Liu commented on code in PR #8772:
URL: https://github.com/apache/texera/pull/8772#discussion_r4261814619
##########
computing-unit-managing-service/src/main/scala/org/apache/texera/service/util/ComputingUnitManagingServiceException.scala:
##########
@@ -37,7 +37,8 @@ final case class InsufficientComputingResource(resourceType: String)
// User has reached the per-user CU-quota (number of running units)
final case class InsufficientComputingUnitQuota(maxNumberOfComputingUnit: Int)
extends ComputingUnitManagingServiceException(
- s"You may only have $maxNumberOfComputingUnit computing-unit(s) running at the same time"
+ s"You may only have $maxNumberOfComputingUnit computing-unit(s) running at the same time. " +
Review Comment:
Still "computing-unit(s)" here. Also, the UI calls these units "Kubernetes", not "cloud" (the type selector and the Terminate message), so "terminate a Kubernetes unit" would match what users see.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(computing-unit-managing-service): say how to free a slot when the CU quota is reached [texera]
Posted by "sshiv012 (via GitHub)" <gi...@apache.org>.
sshiv012 commented on PR #8772:
URL: https://github.com/apache/texera/pull/8772#issuecomment-5960931341
/request-review @Xiao-zhen-Liu
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(computing-unit-managing-service): say how to free a slot when the CU quota is reached [texera]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #8772:
URL: https://github.com/apache/texera/pull/8772#issuecomment-5904615076
## [Codecov](https://app.codecov.io/gh/apache/texera/pull/8772?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 92.59%. Comparing base ([`acc6dd1`](https://app.codecov.io/gh/apache/texera/commit/acc6dd1139d936d849e2aaa6abb288f8ef3e98ad?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`5252a05`](https://app.codecov.io/gh/apache/texera/commit/5252a05f36db19e1cc6c42aeeff7da087a64df5f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #8772 +/- ##
=========================================
Coverage 92.59% 92.59%
Complexity 4962 4962
=========================================
Files 1242 1242
Lines 52883 52884 +1
Branches 6546 6546
=========================================
+ Hits 48965 48966 +1
Misses 2290 2290
Partials 1628 1628
```
| [Flag](https://app.codecov.io/gh/apache/texera/pull/8772/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | *Carryforward flag |
|---|---|---|---|
| [access-control-service](https://app.codecov.io/gh/apache/texera/pull/8772/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `77.38% <ø> (ø)` | | |
| [agent-service](https://app.codecov.io/gh/apache/texera/pull/8772/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `99.16% <ø> (ø)` | | Carriedforward from [acc6dd1](https://app.codecov.io/gh/apache/texera/commit/acc6dd1139d936d849e2aaa6abb288f8ef3e98ad?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [amber](https://app.codecov.io/gh/apache/texera/pull/8772/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `88.06% <ø> (ø)` | | Carriedforward from [acc6dd1](https://app.codecov.io/gh/apache/texera/commit/acc6dd1139d936d849e2aaa6abb288f8ef3e98ad?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [computing-unit-managing-service](https://app.codecov.io/gh/apache/texera/pull/8772/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `60.45% <100.00%> (+0.03%)` | :arrow_up: | |
| [config-service](https://app.codecov.io/gh/apache/texera/pull/8772/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `87.37% <ø> (ø)` | | |
| [file-service](https://app.codecov.io/gh/apache/texera/pull/8772/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `81.53% <ø> (ø)` | | Carriedforward from [acc6dd1](https://app.codecov.io/gh/apache/texera/commit/acc6dd1139d936d849e2aaa6abb288f8ef3e98ad?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [frontend](https://app.codecov.io/gh/apache/texera/pull/8772/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `96.55% <ø> (ø)` | | Carriedforward from [acc6dd1](https://app.codecov.io/gh/apache/texera/commit/acc6dd1139d936d849e2aaa6abb288f8ef3e98ad?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [notebook-migration-service](https://app.codecov.io/gh/apache/texera/pull/8772/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `83.73% <ø> (ø)` | | |
| [pyamber](https://app.codecov.io/gh/apache/texera/pull/8772/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `98.56% <ø> (ø)` | | Carriedforward from [acc6dd1](https://app.codecov.io/gh/apache/texera/commit/acc6dd1139d936d849e2aaa6abb288f8ef3e98ad?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [workflow-compiling-service](https://app.codecov.io/gh/apache/texera/pull/8772/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `74.09% <ø> (ø)` | | |
*This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/texera/pull/8772?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(computing-unit-managing-service): say how to free a slot when the CU quota is reached [texera]
Posted by "Xiao-zhen-Liu (via GitHub)" <gi...@apache.org>.
Xiao-zhen-Liu commented on code in PR #8772:
URL: https://github.com/apache/texera/pull/8772#discussion_r4199579855
##########
computing-unit-managing-service/src/main/scala/org/apache/texera/service/util/ComputingUnitManagingServiceException.scala:
##########
@@ -37,7 +37,8 @@ final case class InsufficientComputingResource(resourceType: String)
// User has reached the per-user CU-quota (number of running units)
final case class InsufficientComputingUnitQuota(maxNumberOfComputingUnit: Int)
extends ComputingUnitManagingServiceException(
- s"You may only have $maxNumberOfComputingUnit computing-unit(s) running at the same time"
+ s"You may only have $maxNumberOfComputingUnit computing-unit(s) running at the same time. " +
Review Comment:
Nit: the first sentence writes "computing-unit(s)" with a hyphen and the new one "computing units". Could the first one become "computing unit(s)", so both spell it the same way? The "(s)" is worth keeping, since the limit can be set to 1. The expected string in the spec changes with it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(computing-unit-managing-service): say how to free a slot when the CU quota is reached [texera]
Posted by "sshiv012 (via GitHub)" <gi...@apache.org>.
sshiv012 commented on PR #8772:
URL: https://github.com/apache/texera/pull/8772#issuecomment-6067266327
Fixed: the hint now says which action frees a slot for cloud and local units.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(computing-unit-managing-service): say how to free a slot when the CU quota is reached [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8772:
URL: https://github.com/apache/texera/pull/8772#issuecomment-5904569629
<!-- texera-reviewer-suggestion -->
### Automated Reviewer Suggestions
Based on the `git blame` history of the changed files, we recommend the following reviewers:
- **Contributors with relevant context:** `@aglinxinyuan`, `@mengw15`
You can notify them by mentioning `@aglinxinyuan`, `@mengw15` in a comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(computing-unit-managing-service): say how to free a slot when the CU quota is reached [texera]
Posted by "sshiv012 (via GitHub)" <gi...@apache.org>.
sshiv012 commented on code in PR #8772:
URL: https://github.com/apache/texera/pull/8772#discussion_r4278540199
##########
computing-unit-managing-service/src/main/scala/org/apache/texera/service/util/ComputingUnitManagingServiceException.scala:
##########
@@ -37,7 +37,8 @@ final case class InsufficientComputingResource(resourceType: String)
// User has reached the per-user CU-quota (number of running units)
final case class InsufficientComputingUnitQuota(maxNumberOfComputingUnit: Int)
extends ComputingUnitManagingServiceException(
- s"You may only have $maxNumberOfComputingUnit computing-unit(s) running at the same time"
+ s"You may only have $maxNumberOfComputingUnit computing-unit(s) running at the same time. " +
Review Comment:
Sorry, missed this one too. Fixed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(computing-unit-managing-service): say how to free a slot when the CU quota is reached [texera]
Posted by "Xiao-zhen-Liu (via GitHub) via notifications" <no...@texera.apache.org>.
Xiao-zhen-Liu merged PR #8772:
URL: https://github.com/apache/texera/pull/8772
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(computing-unit-managing-service): say how to free a slot when the CU quota is reached [texera]
Posted by "sshiv012 (via GitHub) via notifications" <no...@texera.apache.org>.
sshiv012 commented on PR #8772:
URL: https://github.com/apache/texera/pull/8772#issuecomment-6596097492
@Xiao-zhen-Liu can you add this and #8770 and #8771 to merge queue again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org