You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/11/10 16:36:39 UTC

[GitHub] [arrow] wjones127 commented on a change in pull request #11644: ARROW-11938: [R] Enable R build process to find locally built C++ library on Windows [WIP]

wjones127 commented on a change in pull request #11644:
URL: https://github.com/apache/arrow/pull/11644#discussion_r746775382



##########
File path: r/vignettes/developing.Rmd
##########
@@ -154,15 +184,18 @@ You'll first call `cmake` to configure the build and then `make install`. For th
 
 ```{bash, save=run & !sys_install}
 cmake \
+  -G Ninja \
   -DCMAKE_INSTALL_PREFIX=$ARROW_HOME \
   -DCMAKE_INSTALL_LIBDIR=lib \
+  -DARROW_BUILD_SHARED=OFF \
+  -DARROW_BUILD_STATIC=ON \
   -DARROW_COMPUTE=ON \
   -DARROW_CSV=ON \
   -DARROW_DATASET=ON \
   -DARROW_EXTRA_ERROR_CONTEXT=ON \
   -DARROW_FILESYSTEM=ON \
   -DARROW_INSTALL_NAME_RPATH=OFF \
-  -DARROW_JEMALLOC=ON \
+  -DARROW_JEMALLOC=OFF \

Review comment:
       This library isn't supported on Windows.
   
   Curiosity: why is this part of the std build and not listed as an optional component below? Is it required on Linux or Mac OS?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org