You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by "Norman Maurer (JIRA)" <se...@james.apache.org> on 2006/09/29 15:13:50 UTC

[jira] Created: (JAMES-643) Replace all java.net.InetAddress usage with dnsjava

Replace all java.net.InetAddress usage with dnsjava 
----------------------------------------------------

                 Key: JAMES-643
                 URL: http://issues.apache.org/jira/browse/JAMES-643
             Project: James
          Issue Type: Improvement
            Reporter: Norman Maurer
         Assigned To: Norman Maurer
            Priority: Minor
             Fix For: Trunk


We should replace all InetAddress usage with dnsjava

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


[jira] Commented: (JAMES-643) Replace all java.net.InetAddress usage with dnsjava

Posted by "Danny Angus (JIRA)" <se...@james.apache.org>.
    [ http://issues.apache.org/jira/browse/JAMES-643?page=comments#action_12448458 ] 
            
Danny Angus commented on JAMES-643:
-----------------------------------

1) Add DNSServer dependency to the 4 mailets (RemoteDelivery already depends on it)

+0.5 - seems a lot of service to provide just to get the local names

2) Add "getLocalHost()" to MailetContext as a method

-1 do not change MailetContext, this should be managed through mailet-api@
It is perhaps a reasonable thing to add, just not this way.

3) Add localhostaddress and localhostname as well-known properties in the MailetContext. 

+1 Can the DNS service set them up when it initialises()?

This is obviously a symptom of the API's defect (no access to services) it requires an API change which is understood.
I propose thay we use a workaround in the meantime, and well-known properties is the least intrusive

> Replace all java.net.InetAddress usage with dnsjava
> ---------------------------------------------------
>
>                 Key: JAMES-643
>                 URL: http://issues.apache.org/jira/browse/JAMES-643
>             Project: James
>          Issue Type: Improvement
>            Reporter: Norman Maurer
>         Assigned To: Norman Maurer
>            Priority: Minor
>             Fix For: Next Major
>
>
> We should replace all InetAddress usage with dnsjava

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


[jira] Commented: (JAMES-643) Replace all java.net.InetAddress usage with dnsjava

Posted by "Norman Maurer (JIRA)" <se...@james.apache.org>.
    [ http://issues.apache.org/jira/browse/JAMES-643?page=comments#action_12440123 ] 
            
Norman Maurer commented on JAMES-643:
-------------------------------------

I removed all usage. Only some usage is left in mailets. The mailets are:

org.apache.james.transport.mailets:
* AbstractRedirect
* AbstractVirtualUserTable
* DSNBounce
* RemoteDelivery

How to deal with it ? I don't think lookin up the DNSServer via the "mailetContext hack" is a got choice! I whould prefer do add an method to mailetcontext which provide the inderface. Noel prefer jndi if im not wrong..
Any ideas?



> Replace all java.net.InetAddress usage with dnsjava
> ---------------------------------------------------
>
>                 Key: JAMES-643
>                 URL: http://issues.apache.org/jira/browse/JAMES-643
>             Project: James
>          Issue Type: Improvement
>            Reporter: Norman Maurer
>         Assigned To: Norman Maurer
>            Priority: Minor
>             Fix For: Trunk
>
>
> We should replace all InetAddress usage with dnsjava

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


Re: [jira] Commented: (JAMES-643) Replace all java.net.InetAddress usage with dnsjava

Posted by Danny Angus <da...@gmail.com>.
On 11/9/06, Stefano Bagnara <ap...@bago.org> wrote:
> My preference currently is to add code to James.java to lookup the 2
> values from the DNSService and to publish 2 attributes in
> MailetContext's attributes.

+1

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


Re: [jira] Commented: (JAMES-643) Replace all java.net.InetAddress usage with dnsjava

Posted by Norman Maurer <nm...@byteaction.de>.
Danny Angus schrieb:
> On 11/9/06, Stefano Bagnara <ap...@bago.org> wrote:
>> My preference currently is to add code to James.java to lookup the 2
>> values from the DNSService and to publish 2 attributes in
>> MailetContext's attributes.
>
> +1

+1

If noone will add a veto i will do it tomorrow and close the issue :-)

bye
Norman


---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


Re: [jira] Commented: (JAMES-643) Replace all java.net.InetAddress usage with dnsjava

Posted by Stefano Bagnara <ap...@bago.org>.
My preference currently is to add code to James.java to lookup the 2 
values from the DNSService and to publish 2 attributes in 
MailetContext's attributes.

Stefano

Stefano Bagnara (JIRA) wrote:
>     [ http://issues.apache.org/jira/browse/JAMES-643?page=comments#action_12448450 ] 
>             
> Stefano Bagnara commented on JAMES-643:
> ---------------------------------------
> 
> All this 4 mailets use the InetAddress only to get localhost:
> ----
> AbstractRedirect, AbstractVirtualUserTable, DNSBounce, RemoteDelivery
> 
> java.net.InetAddress.getLocalHost().getHostAddress()
> java.net.InetAddress.getLocalHost().getHostName()
> ----
> 
> Imho we have 3 options:
> 1) Add DNSServer dependency to the 4 mailets (RemoteDelivery already depends on it)
> 2) Add "getLocalHost()" to MailetContext as a method
> 3) Add localhostaddress and localhostname as well-known properties in the MailetContext.
> 
> 
>> Replace all java.net.InetAddress usage with dnsjava
>> ---------------------------------------------------
>>
>>                 Key: JAMES-643
>>                 URL: http://issues.apache.org/jira/browse/JAMES-643
>>             Project: James
>>          Issue Type: Improvement
>>            Reporter: Norman Maurer
>>         Assigned To: Norman Maurer
>>            Priority: Minor
>>             Fix For: Next Major
>>
>>
>> We should replace all InetAddress usage with dnsjava
> 



---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


[jira] Commented: (JAMES-643) Replace all java.net.InetAddress usage with dnsjava

Posted by "Stefano Bagnara (JIRA)" <se...@james.apache.org>.
    [ http://issues.apache.org/jira/browse/JAMES-643?page=comments#action_12448450 ] 
            
Stefano Bagnara commented on JAMES-643:
---------------------------------------

All this 4 mailets use the InetAddress only to get localhost:
----
AbstractRedirect, AbstractVirtualUserTable, DNSBounce, RemoteDelivery

java.net.InetAddress.getLocalHost().getHostAddress()
java.net.InetAddress.getLocalHost().getHostName()
----

Imho we have 3 options:
1) Add DNSServer dependency to the 4 mailets (RemoteDelivery already depends on it)
2) Add "getLocalHost()" to MailetContext as a method
3) Add localhostaddress and localhostname as well-known properties in the MailetContext.


> Replace all java.net.InetAddress usage with dnsjava
> ---------------------------------------------------
>
>                 Key: JAMES-643
>                 URL: http://issues.apache.org/jira/browse/JAMES-643
>             Project: James
>          Issue Type: Improvement
>            Reporter: Norman Maurer
>         Assigned To: Norman Maurer
>            Priority: Minor
>             Fix For: Next Major
>
>
> We should replace all InetAddress usage with dnsjava

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


[jira] Resolved: (JAMES-643) Replace all java.net.InetAddress usage with dnsjava

Posted by "Norman Maurer (JIRA)" <se...@james.apache.org>.
     [ http://issues.apache.org/jira/browse/JAMES-643?page=all ]

Norman Maurer resolved JAMES-643.
---------------------------------

    Resolution: Fixed

> Replace all java.net.InetAddress usage with dnsjava
> ---------------------------------------------------
>
>                 Key: JAMES-643
>                 URL: http://issues.apache.org/jira/browse/JAMES-643
>             Project: James
>          Issue Type: Improvement
>            Reporter: Norman Maurer
>         Assigned To: Norman Maurer
>            Priority: Minor
>             Fix For: Next Major
>
>
> We should replace all InetAddress usage with dnsjava

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org