You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2019/04/22 05:14:09 UTC
[kudu-CR] dist-test: support RUN FLAKY ONLY
Hello Mike Percy, Andrew Wong, Grant Henke,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/13072
to review the following change.
Change subject: dist-test: support RUN_FLAKY_ONLY
......................................................................
dist-test: support RUN_FLAKY_ONLY
The flaky test list is somewhat short so there's no real reason for the
tests to be distributed. However, over the years we've observed that the
dist-test runtime environment is different enough from non-dist-test
environments that a test may be flaky in one but not the other. Since the
purpose of flaky test resistance is to improve the precommit experience, and
since all precommit tests run in dist-test, the test runs that power the
flaky test dashboard (i.e. RUN_FLAKY_ONLY=1) should follow suit and also run
in dist-test.
Change-Id: Id5a063512f82341a48031911de12c44f902a2723
---
M build-support/dist_test.py
M build-support/jenkins/build-and-test.sh
M java/buildSrc/src/main/groovy/org/apache/kudu/gradle/DistTestTask.java
3 files changed, 30 insertions(+), 18 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/72/13072/1
--
To view, visit http://gerrit.cloudera.org:8080/13072
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id5a063512f82341a48031911de12c44f902a2723
Gerrit-Change-Number: 13072
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] dist-test: support RUN FLAKY ONLY
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13072 )
Change subject: dist-test: support RUN_FLAKY_ONLY
......................................................................
Patch Set 2: Verified+1
Overriding Jenkins, one dist-test slave had faulty clock synchronization so a slew of tests failed.
--
To view, visit http://gerrit.cloudera.org:8080/13072
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id5a063512f82341a48031911de12c44f902a2723
Gerrit-Change-Number: 13072
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Wed, 24 Apr 2019 04:39:02 +0000
Gerrit-HasComments: No
[kudu-CR] dist-test: support RUN FLAKY ONLY
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13072 )
Change subject: dist-test: support RUN_FLAKY_ONLY
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13072/1/build-support/dist_test.py
File build-support/dist_test.py:
http://gerrit.cloudera.org:8080/#/c/13072/1/build-support/dist_test.py@632
PS1, Line 632: *
Was this star intentional/required? Would **/*%s*.class make sense?
--
To view, visit http://gerrit.cloudera.org:8080/13072
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id5a063512f82341a48031911de12c44f902a2723
Gerrit-Change-Number: 13072
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Wed, 24 Apr 2019 00:43:28 +0000
Gerrit-HasComments: Yes
[kudu-CR] dist-test: support RUN FLAKY ONLY
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13072 )
Change subject: dist-test: support RUN_FLAKY_ONLY
......................................................................
dist-test: support RUN_FLAKY_ONLY
The flaky test list is somewhat short so there's no real reason for the
tests to be distributed. However, over the years we've observed that the
dist-test runtime environment is different enough from non-dist-test
environments that a test may be flaky in one but not the other. Since the
purpose of flaky test resistance is to improve the precommit experience, and
since all precommit tests run in dist-test, the test runs that power the
flaky test dashboard (i.e. RUN_FLAKY_ONLY=1) should follow suit and also run
in dist-test.
Change-Id: Id5a063512f82341a48031911de12c44f902a2723
Reviewed-on: http://gerrit.cloudera.org:8080/13072
Tested-by: Adar Dembo <ad...@cloudera.com>
Reviewed-by: Grant Henke <gr...@apache.org>
---
M build-support/dist_test.py
M build-support/jenkins/build-and-test.sh
M java/buildSrc/src/main/groovy/org/apache/kudu/gradle/DistTestTask.java
3 files changed, 30 insertions(+), 18 deletions(-)
Approvals:
Adar Dembo: Verified
Grant Henke: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/13072
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id5a063512f82341a48031911de12c44f902a2723
Gerrit-Change-Number: 13072
Gerrit-PatchSet: 3
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] dist-test: support RUN FLAKY ONLY
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13072 )
Change subject: dist-test: support RUN_FLAKY_ONLY
......................................................................
Patch Set 1: Verified+1
Overriding Jenkins, unrelated TSAN flaky C++ test failure.
--
To view, visit http://gerrit.cloudera.org:8080/13072
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id5a063512f82341a48031911de12c44f902a2723
Gerrit-Change-Number: 13072
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Mon, 22 Apr 2019 18:27:04 +0000
Gerrit-HasComments: No
[kudu-CR] dist-test: support RUN FLAKY ONLY
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/13072 )
Change subject: dist-test: support RUN_FLAKY_ONLY
......................................................................
Removed reviewer Kudu Jenkins with the following votes:
* Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/13072
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: Id5a063512f82341a48031911de12c44f902a2723
Gerrit-Change-Number: 13072
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] dist-test: support RUN FLAKY ONLY
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13072 )
Change subject: dist-test: support RUN_FLAKY_ONLY
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13072/1/build-support/dist_test.py
File build-support/dist_test.py:
http://gerrit.cloudera.org:8080/#/c/13072/1/build-support/dist_test.py@632
PS1, Line 632: .
> I want this to support use cases like this:
Good catch on this. I agree the trailing * could result in surprising behavior for similar class names.
--
To view, visit http://gerrit.cloudera.org:8080/13072
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id5a063512f82341a48031911de12c44f902a2723
Gerrit-Change-Number: 13072
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Wed, 24 Apr 2019 13:23:08 +0000
Gerrit-HasComments: Yes
[kudu-CR] dist-test: support RUN FLAKY ONLY
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/13072 )
Change subject: dist-test: support RUN_FLAKY_ONLY
......................................................................
Removed reviewer Kudu Jenkins with the following votes:
* Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/13072
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: Id5a063512f82341a48031911de12c44f902a2723
Gerrit-Change-Number: 13072
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] dist-test: support RUN FLAKY ONLY
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13072 )
Change subject: dist-test: support RUN_FLAKY_ONLY
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13072/1/build-support/dist_test.py
File build-support/dist_test.py:
http://gerrit.cloudera.org:8080/#/c/13072/1/build-support/dist_test.py@632
PS1, Line 632: *
> Was this star intentional/required? Would **/*%s*.class make sense?
I want this to support use cases like this:
--pattern=TestAsyncKuduSession
--pattern=TestAsyncKudu*
--pattern=*AsyncKuduSession
--pattern=*AsyncKudu*
--pattern=org.apache.kudu.client.TestAsyncKuduSession
I guess the trailing '*' is only necessary for something like:
--pattern=TestAsyncKudu
So sure, I'll drop it.
--
To view, visit http://gerrit.cloudera.org:8080/13072
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id5a063512f82341a48031911de12c44f902a2723
Gerrit-Change-Number: 13072
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Wed, 24 Apr 2019 03:48:05 +0000
Gerrit-HasComments: Yes
[kudu-CR] dist-test: support RUN FLAKY ONLY
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Hello Mike Percy, Andrew Wong, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13072
to look at the new patch set (#2).
Change subject: dist-test: support RUN_FLAKY_ONLY
......................................................................
dist-test: support RUN_FLAKY_ONLY
The flaky test list is somewhat short so there's no real reason for the
tests to be distributed. However, over the years we've observed that the
dist-test runtime environment is different enough from non-dist-test
environments that a test may be flaky in one but not the other. Since the
purpose of flaky test resistance is to improve the precommit experience, and
since all precommit tests run in dist-test, the test runs that power the
flaky test dashboard (i.e. RUN_FLAKY_ONLY=1) should follow suit and also run
in dist-test.
Change-Id: Id5a063512f82341a48031911de12c44f902a2723
---
M build-support/dist_test.py
M build-support/jenkins/build-and-test.sh
M java/buildSrc/src/main/groovy/org/apache/kudu/gradle/DistTestTask.java
3 files changed, 30 insertions(+), 18 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/72/13072/2
--
To view, visit http://gerrit.cloudera.org:8080/13072
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id5a063512f82341a48031911de12c44f902a2723
Gerrit-Change-Number: 13072
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>