You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by "veghlaci05 (via GitHub)" <gi...@apache.org> on 2023/02/08 15:20:25 UTC
[GitHub] [hive] veghlaci05 commented on a diff in pull request #4024: HIVE-27029: hive query fails with Filesystem closed error, Rework done for HIVE-26352
veghlaci05 commented on code in PR #4024:
URL: https://github.com/apache/hive/pull/4024#discussion_r1100286436
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/YarnQueueHelper.java:
##########
@@ -94,19 +94,15 @@ public YarnQueueHelper(HiveConf conf) {
}
public void checkQueueAccess(
- String queueName, String userName) throws IOException, InterruptedException {
+ String queueName, String userName) throws IOException {
UserGroupInformation ugi = UserGroupInformation.getCurrentUser();
try {
ugi.doAs((PrivilegedExceptionAction<Void>) () -> {
checkQueueAccessInternal(queueName, userName);
return null;
});
- } finally {
- try {
- FileSystem.closeAllForUGI(ugi);
- } catch (IOException exception) {
- LOG.error("Could not clean up file-system handles for UGI: " + ugi, exception);
- }
Review Comment:
@ayushtkn There is no need to call FileSystem.closeAllForUGI(ugi) here, the close is handled elsewhere and worked fine earlier. When I added the `ugi.doAs(...` call in https://github.com/apache/hive/pull/3402, I accidentally added the finally block as well, which is not required here at all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org