You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2017/06/07 01:04:36 UTC
[kudu-CR] log-rolling-itest: delete test files when test ends
Hello Dan Burkert, Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/7100
to review the following change.
Change subject: log-rolling-itest: delete test files when test ends
......................................................................
log-rolling-itest: delete test files when test ends
By not inheriting from the KuduTest fixture, this test didn't clean up
after itself. Normally this is caught in build-and-test.sh by the
TEST_TMPDIR contents check, but precommit jobs use dist-test so the check
only looks at local files.
Change-Id: Ia099401229bbb1d0e3bdf0580c50ae78e49e4b0e
---
M src/kudu/integration-tests/log-rolling-itest.cc
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/00/7100/1
--
To view, visit http://gerrit.cloudera.org:8080/7100
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia099401229bbb1d0e3bdf0580c50ae78e49e4b0e
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] log-rolling-itest: delete test files when test ends
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change.
Change subject: log-rolling-itest: delete test files when test ends
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7100
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia099401229bbb1d0e3bdf0580c50ae78e49e4b0e
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] log-rolling-itest: delete test files when test ends
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: log-rolling-itest: delete test files when test ends
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7100/1/src/kudu/integration-tests/log-rolling-itest.cc
File src/kudu/integration-tests/log-rolling-itest.cc:
Line 46: TEST_F(KuduTest, TestLogCleanupOnStartup) {
> warning: redundant 'test_info_' declaration [readability-redundant-declarat
hrm, I think we usually do a one-line intermediate class like:
class LogRollingITest : public KuduTest {};
so that the output is more specific about the suite.
--
To view, visit http://gerrit.cloudera.org:8080/7100
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia099401229bbb1d0e3bdf0580c50ae78e49e4b0e
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] log-rolling-itest: delete test files when test ends
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: log-rolling-itest: delete test files when test ends
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7100/1/src/kudu/integration-tests/log-rolling-itest.cc
File src/kudu/integration-tests/log-rolling-itest.cc:
Line 46: TEST_F(KuduTest, TestLogCleanupOnStartup) {
> hrm, I think we usually do a one-line intermediate class like:
Done
--
To view, visit http://gerrit.cloudera.org:8080/7100
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia099401229bbb1d0e3bdf0580c50ae78e49e4b0e
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] log-rolling-itest: delete test files when test ends
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has uploaded a new patch set (#2).
Change subject: log-rolling-itest: delete test files when test ends
......................................................................
log-rolling-itest: delete test files when test ends
By not inheriting from the KuduTest fixture, this test didn't clean up
after itself. Normally this is caught in build-and-test.sh by the
TEST_TMPDIR contents check, but precommit jobs use dist-test so the check
only looks at local files.
Change-Id: Ia099401229bbb1d0e3bdf0580c50ae78e49e4b0e
---
M src/kudu/integration-tests/log-rolling-itest.cc
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/00/7100/2
--
To view, visit http://gerrit.cloudera.org:8080/7100
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia099401229bbb1d0e3bdf0580c50ae78e49e4b0e
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] log-rolling-itest: delete test files when test ends
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has submitted this change and it was merged.
Change subject: log-rolling-itest: delete test files when test ends
......................................................................
log-rolling-itest: delete test files when test ends
By not inheriting from the KuduTest fixture, this test didn't clean up
after itself. Normally this is caught in build-and-test.sh by the
TEST_TMPDIR contents check, but precommit jobs use dist-test so the check
only looks at local files.
Change-Id: Ia099401229bbb1d0e3bdf0580c50ae78e49e4b0e
Reviewed-on: http://gerrit.cloudera.org:8080/7100
Tested-by: Kudu Jenkins
Reviewed-by: David Ribeiro Alves <da...@gmail.com>
---
M src/kudu/integration-tests/log-rolling-itest.cc
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
David Ribeiro Alves: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/7100
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia099401229bbb1d0e3bdf0580c50ae78e49e4b0e
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>