You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/11/17 02:49:42 UTC

[GitHub] [shardingsphere] yu199195 opened a new pull request #8181: fix xa transaction get connection bug

yu199195 opened a new pull request #8181:
URL: https://github.com/apache/shardingsphere/pull/8181


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-io commented on pull request #8181: fix xa transaction get connection bug

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #8181:
URL: https://github.com/apache/shardingsphere/pull/8181#issuecomment-728662915


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8181?src=pr&el=h1) Report
   > Merging [#8181](https://codecov.io/gh/apache/shardingsphere/pull/8181?src=pr&el=desc) (0bebae3) into [master](https://codecov.io/gh/apache/shardingsphere/commit/86c5a5120521e6e150ff3ee0e0f3a1b2c70f45bb?el=desc) (86c5a51) will **increase** coverage by `1.64%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/8181/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/shardingsphere/pull/8181?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #8181      +/-   ##
   ============================================
   + Coverage     73.53%   75.18%   +1.64%     
   - Complexity      532      576      +44     
   ============================================
     Files          1446     1457      +11     
     Lines         23042    23191     +149     
     Branches       4141     4152      +11     
   ============================================
   + Hits          16943    17435     +492     
   + Misses         4971     4619     -352     
   - Partials       1128     1137       +9     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/8181?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ication/jdbc/datasource/JDBCBackendDataSource.java](https://codecov.io/gh/apache/shardingsphere/pull/8181/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9jb21tdW5pY2F0aW9uL2pkYmMvZGF0YXNvdXJjZS9KREJDQmFja2VuZERhdGFTb3VyY2UuamF2YQ==) | `84.61% <100.00%> (+0.61%)` | `1.00 <0.00> (ø)` | |
   | [...ingsphere/scaling/core/job/ShardingScalingJob.java](https://codecov.io/gh/apache/shardingsphere/pull/8181/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9qb2IvU2hhcmRpbmdTY2FsaW5nSm9iLmphdmE=) | `90.90% <0.00%> (-9.10%)` | `0.00% <0.00%> (ø%)` | |
   | [...g/core/job/position/FinishedInventoryPosition.java](https://codecov.io/gh/apache/shardingsphere/pull/8181/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9qb2IvcG9zaXRpb24vRmluaXNoZWRJbnZlbnRvcnlQb3NpdGlvbi5qYXZh) | `60.00% <0.00%> (-6.67%)` | `1.00% <0.00%> (+1.00%)` | :arrow_down: |
   | [...ore/job/position/PlaceholderInventoryPosition.java](https://codecov.io/gh/apache/shardingsphere/pull/8181/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9qb2IvcG9zaXRpb24vUGxhY2Vob2xkZXJJbnZlbnRvcnlQb3NpdGlvbi5qYXZh) | `60.00% <0.00%> (-6.67%)` | `1.00% <0.00%> (+1.00%)` | :arrow_down: |
   | [...d/query/binary/bind/PostgreSQLComBindExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/8181/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQtcG9zdGdyZXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvZnJvbnRlbmQvcG9zdGdyZXNxbC9jb21tYW5kL3F1ZXJ5L2JpbmFyeS9iaW5kL1Bvc3RncmVTUUxDb21CaW5kRXhlY3V0b3IuamF2YQ==) | `8.51% <0.00%> (-1.91%)` | `0.00% <0.00%> (ø%)` | |
   | [...he/shardingsphere/scaling/mysql/MySQLImporter.java](https://codecov.io/gh/apache/shardingsphere/pull/8181/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLW15c3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zY2FsaW5nL215c3FsL015U1FMSW1wb3J0ZXIuamF2YQ==) | `100.00% <0.00%> (ø)` | `1.00% <0.00%> (ø%)` | |
   | [...ingsphere/scaling/mysql/binlog/BinlogPosition.java](https://codecov.io/gh/apache/shardingsphere/pull/8181/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLW15c3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zY2FsaW5nL215c3FsL2JpbmxvZy9CaW5sb2dQb3NpdGlvbi5qYXZh) | `88.88% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | [...dingsphere/scaling/postgresql/wal/WalPosition.java](https://codecov.io/gh/apache/shardingsphere/pull/8181/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLXBvc3RncmVzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvcG9zdGdyZXNxbC93YWwvV2FsUG9zaXRpb24uamF2YQ==) | `87.50% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | [...ere/scaling/core/datasource/DataSourceWrapper.java](https://codecov.io/gh/apache/shardingsphere/pull/8181/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9kYXRhc291cmNlL0RhdGFTb3VyY2VXcmFwcGVyLmphdmE=) | `19.04% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | [.../proxy/backend/text/query/QueryBackendHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/8181/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L3F1ZXJ5L1F1ZXJ5QmFja2VuZEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | ... and [72 more](https://codecov.io/gh/apache/shardingsphere/pull/8181/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8181?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8181?src=pr&el=footer). Last update [86c5a51...0bebae3](https://codecov.io/gh/apache/shardingsphere/pull/8181?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] terrymanu merged pull request #8181: fix xa transaction get connection bug

Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #8181:
URL: https://github.com/apache/shardingsphere/pull/8181


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-io edited a comment on pull request #8181: fix xa transaction get connection bug

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #8181:
URL: https://github.com/apache/shardingsphere/pull/8181#issuecomment-728662915


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8181?src=pr&el=h1) Report
   > Merging [#8181](https://codecov.io/gh/apache/shardingsphere/pull/8181?src=pr&el=desc) (0bebae3) into [master](https://codecov.io/gh/apache/shardingsphere/commit/86c5a5120521e6e150ff3ee0e0f3a1b2c70f45bb?el=desc) (86c5a51) will **increase** coverage by `1.64%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/8181/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/shardingsphere/pull/8181?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #8181      +/-   ##
   ============================================
   + Coverage     73.53%   75.18%   +1.64%     
   - Complexity      532      576      +44     
   ============================================
     Files          1446     1457      +11     
     Lines         23042    23191     +149     
     Branches       4141     4152      +11     
   ============================================
   + Hits          16943    17435     +492     
   + Misses         4971     4619     -352     
   - Partials       1128     1137       +9     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/8181?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ication/jdbc/datasource/JDBCBackendDataSource.java](https://codecov.io/gh/apache/shardingsphere/pull/8181/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9jb21tdW5pY2F0aW9uL2pkYmMvZGF0YXNvdXJjZS9KREJDQmFja2VuZERhdGFTb3VyY2UuamF2YQ==) | `84.61% <100.00%> (+0.61%)` | `1.00 <0.00> (ø)` | |
   | [...ingsphere/scaling/core/job/ShardingScalingJob.java](https://codecov.io/gh/apache/shardingsphere/pull/8181/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9qb2IvU2hhcmRpbmdTY2FsaW5nSm9iLmphdmE=) | `90.90% <0.00%> (-9.10%)` | `0.00% <0.00%> (ø%)` | |
   | [...g/core/job/position/FinishedInventoryPosition.java](https://codecov.io/gh/apache/shardingsphere/pull/8181/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9qb2IvcG9zaXRpb24vRmluaXNoZWRJbnZlbnRvcnlQb3NpdGlvbi5qYXZh) | `60.00% <0.00%> (-6.67%)` | `1.00% <0.00%> (+1.00%)` | :arrow_down: |
   | [...ore/job/position/PlaceholderInventoryPosition.java](https://codecov.io/gh/apache/shardingsphere/pull/8181/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9qb2IvcG9zaXRpb24vUGxhY2Vob2xkZXJJbnZlbnRvcnlQb3NpdGlvbi5qYXZh) | `60.00% <0.00%> (-6.67%)` | `1.00% <0.00%> (+1.00%)` | :arrow_down: |
   | [...d/query/binary/bind/PostgreSQLComBindExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/8181/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQtcG9zdGdyZXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvZnJvbnRlbmQvcG9zdGdyZXNxbC9jb21tYW5kL3F1ZXJ5L2JpbmFyeS9iaW5kL1Bvc3RncmVTUUxDb21CaW5kRXhlY3V0b3IuamF2YQ==) | `8.51% <0.00%> (-1.91%)` | `0.00% <0.00%> (ø%)` | |
   | [...he/shardingsphere/scaling/mysql/MySQLImporter.java](https://codecov.io/gh/apache/shardingsphere/pull/8181/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLW15c3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zY2FsaW5nL215c3FsL015U1FMSW1wb3J0ZXIuamF2YQ==) | `100.00% <0.00%> (ø)` | `1.00% <0.00%> (ø%)` | |
   | [...ingsphere/scaling/mysql/binlog/BinlogPosition.java](https://codecov.io/gh/apache/shardingsphere/pull/8181/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLW15c3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zY2FsaW5nL215c3FsL2JpbmxvZy9CaW5sb2dQb3NpdGlvbi5qYXZh) | `88.88% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | [...dingsphere/scaling/postgresql/wal/WalPosition.java](https://codecov.io/gh/apache/shardingsphere/pull/8181/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLXBvc3RncmVzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvcG9zdGdyZXNxbC93YWwvV2FsUG9zaXRpb24uamF2YQ==) | `87.50% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | [...ere/scaling/core/datasource/DataSourceWrapper.java](https://codecov.io/gh/apache/shardingsphere/pull/8181/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9kYXRhc291cmNlL0RhdGFTb3VyY2VXcmFwcGVyLmphdmE=) | `19.04% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | [.../proxy/backend/text/query/QueryBackendHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/8181/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L3F1ZXJ5L1F1ZXJ5QmFja2VuZEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | ... and [72 more](https://codecov.io/gh/apache/shardingsphere/pull/8181/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8181?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8181?src=pr&el=footer). Last update [86c5a51...0bebae3](https://codecov.io/gh/apache/shardingsphere/pull/8181?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org