You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2020/05/03 22:43:58 UTC

[GitHub] [phoenix-queryserver] joshelser commented on a change in pull request #31: PHOENIX-5879 Fix recently introduced python 2.7 incompatibilities and…

joshelser commented on a change in pull request #31:
URL: https://github.com/apache/phoenix-queryserver/pull/31#discussion_r419170436



##########
File path: python/phoenixdb/README.rst
##########
@@ -85,12 +70,15 @@ the `PYTHONPATH` environment variable to point to the library directly::
     cd ~/my_project
     PYTHONPATH=$PHOENIX_HOME/build/lib python my_app.py
 
+Don't forget to run flake8 on your changes.
+
 Interactive SQL shell
 ---------------------
 
 There is a Python-based interactive shell include in the examples folder, which can be
 used to connect to Phoenix and execute queries::
 
+    pip install -r ./examples/requirements.txt
     ./examples/shell.py http://localhost:8765/

Review comment:
       Sounds good.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org