[jira] [Commented] (HDFS-7897) Shutdown metrics when stopping JournalNode

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HDFS-7897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14349981#comment-14349981 ] 

Hadoop QA commented on HDFS-7897:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12702960/HDFS-7897-001.patch
  against trunk revision 952640f.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:

                  org.apache.hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA

                                      The following test timeouts occurred in hadoop-hdfs-project/hadoop-hdfs:

org.apache.hadoop.hdfs.server.namenode.ha.TestPipelinesFailover

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/9762//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9762//console

This message is automatically generated.

> Shutdown metrics when stopping JournalNode
> ------------------------------------------
>
>                 Key: HDFS-7897
>                 URL: https://issues.apache.org/jira/browse/HDFS-7897
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 2.6.0
>            Reporter: zhouyingchao
>            Assignee: zhouyingchao
>         Attachments: HDFS-7897-001.patch
>
>
> In JournalNode.stop(), the metrics system is forgotten to shutdown. The issue is found when reading the code.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)