You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jetspeed-dev@portals.apache.org by David Sean Taylor <da...@bluesunrise.com> on 2002/07/19 22:11:00 UTC
RE: [PATCH] was: [ENHANCEMENT] support for adding existing port lets and categoryfilter in customizer-portletset-add.vm
RE: [PATCH] was: [ENHANCEMENT] support for adding existing port lets and
categoryfilter in customizer-portletset-add.vmScott,
I've been testing and it seems to be working now.
Try this:
Customize the admin user.
Move the Secuity tab up one in the tab ordering.
Save it.
The Security tab doesn't get moved to the first position, however it is
selected the next time a logon.
Im going to commit the patch anyway. Seems to be working besides this small
problem
David
-----Original Message-----
From: Weaver, Scott [mailto:Sweaver@rippe.com]
Sent: Friday, July 19, 2002 11:57 AM
To: 'Jetspeed Developers List'
Subject: RE: [PATCH] was: [ENHANCEMENT] support for adding existing port
lets and categoryfilter in customizer-portletset-add.vm
David,
I tested this against a fresh CVS HEAD and my implementation and
everything seems to be working correctly. This fix will check for
duplicated positions (the root cause of the issue). If a duplicated
position is found, the last position in the TreeSet is located, incremented
by one and used as the new position for the duplicate.
Scott
> -----Original Message-----
> From: Weaver, Scott [mailto:Sweaver@rippe.com]
> Sent: Friday, July 19, 2002 1:25 PM
> To: 'Jetspeed Developers List'
> Subject: RE: [PATCH] was: [ENHANCEMENT] support for adding existing port
> lets and categoryfilter in customizer-portletset-add.vm
>
> David,
>
> I expected all portlets in all profiles to have a position attribute,
this
> is not always the case. I'll get the fix out pronto!
>
> Sorry for the inconvenience,
> Scott
>
>
> > -----Original Message-----
> > From: Weaver, Scott [mailto:Sweaver@rippe.com]
> > Sent: Friday, July 19, 2002 1:10 PM
> > To: 'Jetspeed Developers List'
> > Subject: RE: [PATCH] was: [ENHANCEMENT] support for adding existing
port
> > lets and categoryfilter in customizer-portletset-add.vm
> >
> > I grab HEAD and test it.
> >
> > Scott
> >
> >
> >
> > > -----Original Message-----
> > > From: David Sean Taylor [mailto:david@bluesunrise.com]
> > > Sent: Friday, July 19, 2002 1:00 PM
> > > To: Jetspeed Developers List
> > > Subject: RE: [PATCH] was: [ENHANCEMENT] support for adding existing
> > > portlets and categoryfilter in customizer-portletset-add.vm
> > >
> > >
> > > It was the tab ordering patch
> > > Haven't tried your customizer patch yet
> > >
> > > > -----Original Message-----
> > > > From: Weaver, Scott [mailto:Sweaver@rippe.com]
> > > > Sent: Friday, July 19, 2002 10:53 AM
> > > > To: 'Jetspeed Developers List'
> > > > Subject: RE: [PATCH] was: [ENHANCEMENT] support for adding
existing
> > > > portlets and categoryfilter in customizer-portletset-add.vm
> > > >
> > > >
> > > > > The tabs are no longer working from the cvs head.
> > > > Was it a problem with the customizer enhancement or the Tab
> > > > Ordering/Tab security patch?
> > > >
> > > >
> > > > > -----Original Message-----
> > > > > From: David Sean Taylor [mailto:david@bluesunrise.com]
> > > > > Sent: Friday, July 19, 2002 12:40 PM
> > > > > To: Jetspeed Developers List
> > > > > Subject: RE: [PATCH] was: [ENHANCEMENT] support for adding
> existing
> > > > > portlets and categoryfilter in customizer-portletset-add.vm
> > > > >
> > > > > [PATCH] was: [ENHANCEMENT] support for adding existing portlets
> and
> > > > > categoryfilter in customizer-portletset-add.vmScott,
> > > > >
> > > > > I guess I should've did some better quality control.
> > > > > The tabs are no longer working from the cvs head.
> > > > > Looks like my patch utility my have screwed up. Could you please
> > > review
> > > > > the
> > > > > code and see what went wrong?
> > > > > I will then apply your latest patch
> > > > >
> > > > > Thanks and sorry,
> > > > >
> > > > > David
> > > > > -----Original Message-----
> > > > > From: Weaver, Scott [mailto:Sweaver@rippe.com]
> > > > > Sent: Friday, July 19, 2002 10:33 AM
> > > > > To: 'Jetspeed Developers List'
> > > > > Subject: RE: [PATCH] was: [ENHANCEMENT] support for adding
> > existing
> > > > > portlets and categoryfilter in customizer-portletset-add.vm
> > > > >
> > > > >
> > > > > David,
> > > > >
> > > > >
> > > > >
> > > > > I forgot to include the checkmark image I used. Here it is.
> > > > >
> > > > >
> > > > >
> > > > > Scott
> > > > >
> > > > >
> > > > >
> > > > > -----Original Message-----
> > > > > From: Weaver, Scott [mailto:Sweaver@rippe.com]
> > > > > Sent: Friday, July 19, 2002 12:25 PM
> > > > > To: 'Jetspeed Developers List'
> > > > > Subject: [PATCH] was: [ENHANCEMENT] support for adding
> > > > existing portlets
> > > > > and categoryfilter in customizer-portletset-add.vm
> > > > >
> > > > >
> > > > >
> > > > > Here ya' go.
> > > > >
> > > > > Scott
> > > > >
> > > > > > -----Original Message-----
> > > > > > From: Weaver, Scott [mailto:Sweaver@rippe.com]
> > > > > > Sent: Friday, July 19, 2002 6:27 AM
> > > > > > To: 'Jetspeed Developers List'
> > > > > > Subject: [ENHANCEMENT] support for adding existing portlets
> and
> > > > > > categoryfilter in customizer-portletset-add.vm
> > > > > >
> > > > > >
> > > > > > Enhancements to customizer-portletset-add.vm:
> > > > > >
> > > > > > 1. A user can now add as many of the same portlet to a pane
> as
> > > they
> > > > > > like. This is supported by existing logic 1.4b1 but I have
> > > > yet to see
> > > > > > the ability to use it through the customizer portlet.
> > > > > +1
> > > > > After all the work Paul, Glenn and I did to get this to work,
> it's
> > > all
> > > > > pointless if the feature is disabled in the customizer.
> > > > >
> > > > > >
> > > > > > 2. Added an option list that allows the user to filter
> portlets
> > > by
> > > > > > category. I had to modify CustomizeSetAction to build a
> > > > category list
> > > > > > that is put into the page context.
> > > > > +1
> > > > > Great!
> > > > >
> > > > > >
> > > > > > I will be adding the group filter functionality later.
> > > > > >
> > > > > > Let me know if this is of interest, and I will submit the
> > patches.
> > > > >
> > > > > Patches are always welcome !
> > > > >
> > > > > David
> > > > >
> > > > > >
> > > > >
> > > > >
> > > > >
> > > > > --
> > > > > To unsubscribe, e-mail:
> > > > > <ma...@jakarta.apache.org>
> > > > > For additional commands, e-mail:
> > > > > <ma...@jakarta.apache.org>
> > > > >
> > > > >
> > > > >
> > > > >
> > > >
> > > >
> > >
> > >
> > >
> > > --
> > > To unsubscribe, e-mail: <mailto:jetspeed-dev-
> > > unsubscribe@jakarta.apache.org>
> > > For additional commands, e-mail: <mailto:jetspeed-dev-
> > > help@jakarta.apache.org>