You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Peter Bacsko via Review Board <no...@reviews.apache.org> on 2018/05/15 12:43:26 UTC
Review Request 67129: OOZIE-3240 Flaky test
TestJMSAccessorService#testConnectionRetry
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67129/
-----------------------------------------------------------
Review request for oozie, András Piros and Peter Cseh.
Repository: oozie-git
Description
-------
Proposed fir for OOZIE-3240.
Note that most likely this patch will also solve OOZIE-3239 (or other tests that fail in this class).
Diffs
-----
core/src/test/java/org/apache/oozie/service/TestJMSAccessorService.java 41241d2533bf6c3f32f0fca5d76ad5b960bff1a1
core/src/test/java/org/apache/oozie/test/XTestCase.java f471b889896e9a37a59c3b8ad1c47633eed3e0c0
Diff: https://reviews.apache.org/r/67129/diff/1/
Testing
-------
Thanks,
Peter Bacsko
Re: Review Request 67129: OOZIE-3240 Flaky test
TestJMSAccessorService#testConnectionRetry
Posted by András Piros via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67129/#review203110
-----------------------------------------------------------
core/src/test/java/org/apache/oozie/service/TestJMSAccessorService.java
Lines 160 (patched)
<https://reviews.apache.org/r/67129/#comment285187>
Wouldn't use lambdas, an anonymous class is better IMO.
core/src/test/java/org/apache/oozie/service/TestJMSAccessorService.java
Line 226 (original), 207 (patched)
<https://reviews.apache.org/r/67129/#comment285186>
Wouldn't use lambdas, an anonymous class is better IMO.
core/src/test/java/org/apache/oozie/service/TestJMSAccessorService.java
Line 265 (original), 252 (patched)
<https://reviews.apache.org/r/67129/#comment285185>
Wouldn't use lambdas, an anonymous class is better IMO.
core/src/test/java/org/apache/oozie/test/XTestCase.java
Lines 806-813 (patched)
<https://reviews.apache.org/r/67129/#comment285188>
Nice :)
- András Piros
On May 15, 2018, 12:43 p.m., Peter Bacsko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67129/
> -----------------------------------------------------------
>
> (Updated May 15, 2018, 12:43 p.m.)
>
>
> Review request for oozie, András Piros and Peter Cseh.
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> Proposed fir for OOZIE-3240.
>
> Note that most likely this patch will also solve OOZIE-3239 (or other tests that fail in this class).
>
>
> Diffs
> -----
>
> core/src/test/java/org/apache/oozie/service/TestJMSAccessorService.java 41241d2533bf6c3f32f0fca5d76ad5b960bff1a1
> core/src/test/java/org/apache/oozie/test/XTestCase.java f471b889896e9a37a59c3b8ad1c47633eed3e0c0
>
>
> Diff: https://reviews.apache.org/r/67129/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Peter Bacsko
>
>
Re: Review Request 67129: OOZIE-3240 Flaky test
TestJMSAccessorService#testConnectionRetry
Posted by András Piros via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67129/#review203112
-----------------------------------------------------------
Ship it!
Ship It!
- András Piros
On May 15, 2018, 1:17 p.m., Peter Bacsko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67129/
> -----------------------------------------------------------
>
> (Updated May 15, 2018, 1:17 p.m.)
>
>
> Review request for oozie, András Piros and Peter Cseh.
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> Proposed fir for OOZIE-3240.
>
> Note that most likely this patch will also solve OOZIE-3239 (or other tests that fail in this class) and OOZIE-3241.
>
>
> Diffs
> -----
>
> core/src/test/java/org/apache/oozie/service/TestJMSAccessorService.java 41241d2533bf6c3f32f0fca5d76ad5b960bff1a1
>
>
> Diff: https://reviews.apache.org/r/67129/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Peter Bacsko
>
>
Re: Review Request 67129: OOZIE-3240 Flaky test
TestJMSAccessorService#testConnectionRetry
Posted by Peter Bacsko via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67129/
-----------------------------------------------------------
(Updated máj. 15, 2018, 1:17 du)
Review request for oozie, András Piros and Peter Cseh.
Repository: oozie-git
Description
-------
Proposed fir for OOZIE-3240.
Note that most likely this patch will also solve OOZIE-3239 (or other tests that fail in this class) and OOZIE-3241.
Diffs (updated)
-----
core/src/test/java/org/apache/oozie/service/TestJMSAccessorService.java 41241d2533bf6c3f32f0fca5d76ad5b960bff1a1
Diff: https://reviews.apache.org/r/67129/diff/2/
Changes: https://reviews.apache.org/r/67129/diff/1-2/
Testing
-------
Thanks,
Peter Bacsko
Re: Review Request 67129: OOZIE-3240 Flaky test
TestJMSAccessorService#testConnectionRetry
Posted by Peter Bacsko via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67129/
-----------------------------------------------------------
(Updated máj. 15, 2018, 12:52 du)
Review request for oozie, András Piros and Peter Cseh.
Repository: oozie-git
Description (updated)
-------
Proposed fir for OOZIE-3240.
Note that most likely this patch will also solve OOZIE-3239 (or other tests that fail in this class) and OOZIE-3241.
Diffs
-----
core/src/test/java/org/apache/oozie/service/TestJMSAccessorService.java 41241d2533bf6c3f32f0fca5d76ad5b960bff1a1
core/src/test/java/org/apache/oozie/test/XTestCase.java f471b889896e9a37a59c3b8ad1c47633eed3e0c0
Diff: https://reviews.apache.org/r/67129/diff/1/
Testing
-------
Thanks,
Peter Bacsko
Re: Review Request 67129: OOZIE-3240 Flaky test
TestJMSAccessorService#testConnectionRetry
Posted by Peter Bacsko via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67129/#review203109
-----------------------------------------------------------
core/src/test/java/org/apache/oozie/service/TestJMSAccessorService.java
Line 86 (original)
<https://reviews.apache.org/r/67129/#comment285182>
I removed these catch blocks, they didn't serve any purpose whatsoever.
core/src/test/java/org/apache/oozie/service/TestJMSAccessorService.java
Lines 142-146 (original), 127 (patched)
<https://reviews.apache.org/r/67129/#comment285183>
This was absolutely unnecessary here.
core/src/test/java/org/apache/oozie/test/XTestCase.java
Lines 806 (patched)
<https://reviews.apache.org/r/67129/#comment285184>
Small enhancement for JDK8.
- Peter Bacsko
On máj. 15, 2018, 12:43 du, Peter Bacsko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67129/
> -----------------------------------------------------------
>
> (Updated máj. 15, 2018, 12:43 du)
>
>
> Review request for oozie, András Piros and Peter Cseh.
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> Proposed fir for OOZIE-3240.
>
> Note that most likely this patch will also solve OOZIE-3239 (or other tests that fail in this class).
>
>
> Diffs
> -----
>
> core/src/test/java/org/apache/oozie/service/TestJMSAccessorService.java 41241d2533bf6c3f32f0fca5d76ad5b960bff1a1
> core/src/test/java/org/apache/oozie/test/XTestCase.java f471b889896e9a37a59c3b8ad1c47633eed3e0c0
>
>
> Diff: https://reviews.apache.org/r/67129/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Peter Bacsko
>
>