You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2021/07/16 03:30:08 UTC
[GitHub] [commons-csv] belugabehr opened a new pull request #169: CSV-285: Replace BufferedReader with PushbackReader
belugabehr opened a new pull request #169:
URL: https://github.com/apache/commons-csv/pull/169
https://issues.apache.org/jira/browse/CSV-285
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-csv] belugabehr commented on pull request #169: CSV-285: Replace BufferedReader with PushbackReader
Posted by GitBox <gi...@apache.org>.
belugabehr commented on pull request #169:
URL: https://github.com/apache/commons-csv/pull/169#issuecomment-881499609
@garydgregory
Weird timing that I just happened to pick up CSV commons work the other day. I thought I was making big progress on performance, but my research just revealed that there was a big performance regression as part of adding support for String delimiters #76 which was just added to master recently. My contributions this week made some incremental improvements, but really the big performance improvement I addressed in #167 which bypasses the work in #76 by short-circuiting for the common use case of a single delimiter character. With #167 in place, the performance is much more similar to the current 1.8 version and not nearly as impressive as I had thought.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-csv] garydgregory commented on pull request #169: CSV-285: Replace BufferedReader with PushbackReader
Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #169:
URL: https://github.com/apache/commons-csv/pull/169#issuecomment-1046060445
Hi @belugabehr,
Please note that I merged a bug fix today related to string delimiters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-csv] belugabehr commented on pull request #169: CSV-285: Replace BufferedReader with PushbackReader
Posted by GitBox <gi...@apache.org>.
belugabehr commented on pull request #169:
URL: https://github.com/apache/commons-csv/pull/169#issuecomment-881485678
Ya, all the unit tests pass, but I definitely see some flaws in my attempt here. Do not commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-csv] garydgregory commented on pull request #169: CSV-285: Replace BufferedReader with PushbackReader
Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #169:
URL: https://github.com/apache/commons-csv/pull/169#issuecomment-881383562
No rush. I might cut a release candidate next week or so but this is a major change we might only want to do after that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-csv] belugabehr commented on pull request #169: CSV-285: Replace BufferedReader with PushbackReader
Posted by GitBox <gi...@apache.org>.
belugabehr commented on pull request #169:
URL: https://github.com/apache/commons-csv/pull/169#issuecomment-881152812
Hold off on this one for right now, the JMH tests are not as favorable as I was expected. I need to review the tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-csv] belugabehr edited a comment on pull request #169: CSV-285: Replace BufferedReader with PushbackReader
Posted by GitBox <gi...@apache.org>.
belugabehr edited a comment on pull request #169:
URL: https://github.com/apache/commons-csv/pull/169#issuecomment-881152812
Hold off on this one for right now, the JMH tests are not as favorable as I was expecting. I need to review the tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-csv] coveralls commented on pull request #169: CSV-285: Replace BufferedReader with PushbackReader
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #169:
URL: https://github.com/apache/commons-csv/pull/169#issuecomment-881167323
[](https://coveralls.io/builds/41419456)
Coverage decreased (-0.3%) to 97.99% when pulling **532a3f10eea650e252d32737ec560e0287114606 on belugabehr:CSV-285** into **27843d8dc0ec6e5af910674bfb4cba4e48b2475b on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org