You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2021/01/18 12:50:18 UTC
[GitHub] [lucene-solr] timatbw opened a new pull request #2216: SOLR-15085 Prevent EmbeddedSolrServer calling shutdown on a CoreConta…
timatbw opened a new pull request #2216:
URL: https://github.com/apache/lucene-solr/pull/2216
…iner that was passed to it
<!--
_(If you are a project committer then you may remove some/all of the following template.)_
Before creating a pull request, please file an issue in the ASF Jira system for Lucene or Solr:
* https://issues.apache.org/jira/projects/LUCENE
* https://issues.apache.org/jira/projects/SOLR
You will need to create an account in Jira in order to create an issue.
The title of the PR should reference the Jira issue number in the form:
* LUCENE-####: <short description of problem or changes>
* SOLR-####: <short description of problem or changes>
LUCENE and SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on.
Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. -->
# Description
Prevent EmbeddedSolrServer calling shutdown on a CoreContainer that was passed to it.
# Solution
Now keeping track of whether the CoreContainer was provided or created internally and only calling shutdown for internally-created instances.
# Tests
Modified appropriate test to confirm behaviour, and removed overrides used in existing tests to workaround this issue.
# Checklist
Please review the following and check all that apply:
- [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [x] I have created a Jira issue and added the issue ID to my pull request title.
- [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [x] I have developed this patch against the `master` branch.
- [x] I have run `./gradlew check`.
- [x] I have added tests for my changes.
- [ ] I have added documentation for the [Ref Guide](https://github.com/apache/lucene-solr/tree/master/solr/solr-ref-guide) (for Solr changes only).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] madrob closed pull request #2216: SOLR-15085 Prevent EmbeddedSolrServer calling shutdown on a CoreConta…
Posted by GitBox <gi...@apache.org>.
madrob closed pull request #2216:
URL: https://github.com/apache/lucene-solr/pull/2216
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] madrob commented on a change in pull request #2216: SOLR-15085 Prevent EmbeddedSolrServer calling shutdown on a CoreConta…
Posted by GitBox <gi...@apache.org>.
madrob commented on a change in pull request #2216:
URL: https://github.com/apache/lucene-solr/pull/2216#discussion_r560589531
##########
File path: solr/core/src/java/org/apache/solr/client/solrj/embedded/EmbeddedSolrServer.java
##########
@@ -71,6 +71,7 @@
protected final String coreName;
private final SolrRequestParsers _parser;
private final RequestWriterSupplier supplier;
+ private boolean containerIsLocal = false;
Review comment:
I think we can pass null from the other constructors and in the final constructor if the cc is still null we create one and set local to true?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] timatbw commented on a change in pull request #2216: SOLR-15085 Prevent EmbeddedSolrServer calling shutdown on a CoreConta…
Posted by GitBox <gi...@apache.org>.
timatbw commented on a change in pull request #2216:
URL: https://github.com/apache/lucene-solr/pull/2216#discussion_r559642959
##########
File path: solr/core/src/java/org/apache/solr/client/solrj/embedded/EmbeddedSolrServer.java
##########
@@ -71,6 +71,7 @@
protected final String coreName;
private final SolrRequestParsers _parser;
private final RequestWriterSupplier supplier;
+ private boolean containerIsLocal = false;
Review comment:
I tried to do that, but it gets awkward because there's 5 constructors and one calls another which calls another. I'd have to refactor all of them to call a private constructor instead, to avoid changing the external constructor parameters. Do you think I should I do that?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] timatbw commented on a change in pull request #2216: SOLR-15085 Prevent EmbeddedSolrServer calling shutdown on a CoreConta…
Posted by GitBox <gi...@apache.org>.
timatbw commented on a change in pull request #2216:
URL: https://github.com/apache/lucene-solr/pull/2216#discussion_r560811466
##########
File path: solr/core/src/java/org/apache/solr/client/solrj/embedded/EmbeddedSolrServer.java
##########
@@ -71,6 +71,7 @@
protected final String coreName;
private final SolrRequestParsers _parser;
private final RequestWriterSupplier supplier;
+ private boolean containerIsLocal = false;
Review comment:
That would be good, but there's no context available to create a cc because the original parameters (e.g. NodeConfig or solrHome Path) aren't in scope then.
I'm not that worried about this boolean flag because it's private to the class so we know where it's set.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] madrob commented on a change in pull request #2216: SOLR-15085 Prevent EmbeddedSolrServer calling shutdown on a CoreConta…
Posted by GitBox <gi...@apache.org>.
madrob commented on a change in pull request #2216:
URL: https://github.com/apache/lucene-solr/pull/2216#discussion_r559611053
##########
File path: solr/core/src/java/org/apache/solr/client/solrj/embedded/EmbeddedSolrServer.java
##########
@@ -71,6 +71,7 @@
protected final String coreName;
private final SolrRequestParsers _parser;
private final RequestWriterSupplier supplier;
+ private boolean containerIsLocal = false;
Review comment:
Can this be final?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] madrob commented on pull request #2216: SOLR-15085 Prevent EmbeddedSolrServer calling shutdown on a CoreConta…
Posted by GitBox <gi...@apache.org>.
madrob commented on pull request #2216:
URL: https://github.com/apache/lucene-solr/pull/2216#issuecomment-769935182
Added upgrade notes, pushed to branch_8x and master! Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org