You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by dpogue <gi...@git.apache.org> on 2014/10/03 01:18:52 UTC
[GitHub] cordova-lib pull request: xxhdpi/xxxhdpi and 9-patch splash image ...
GitHub user dpogue opened a pull request:
https://github.com/apache/cordova-lib/pull/97
xxhdpi/xxxhdpi and 9-patch splash image support for Android
This combines #89 and #87 so that they won't conflict with each other.
/cc @sgrebnov
From #89:
> https://issues.apache.org/jira/browse/CB-7607
>
> Current Cordova template for Android does not have res sub-folders for xx and xxxhdpi plus due to current
> splash/icons support implementation it is possible to replace already existing drawables only(see var
> densities = this.deleteDefaultResource(...)). I don't think we should always keep new hi res images as part
> of default template due to the their big size so this commit improves splash/icons support implementation
> to make it possible to add drawables for the densities which are not present in template by default.
>
> Example configuration for xxhdpi and xxxhdpi assets:
>
> ```
> <icon src="res/android/xxhdpi.png" density="xxhdpi" />
> <icon src="res/android/xxxhdpi.png" density="xxxhdpi" />
>
> <splash src="res/android/land-xxhdpi.png" density="land-xxhdpi" />
> <splash src="res/android/port-xxhdpi.png" density="port-xxhdpi" />
>
> <splash src="res/android/land-xxxhdpi.png" density="land-xxxhdpi" />
> <splash src="res/android/port-xxxhdpi.png" density="port-xxxhdpi" />
> ```
From #87:
> https://issues.apache.org/jira/browse/CB-7598
>
> If a splashscreen image for Android is specified in config.xml and ends with .9.png, it is a 9-patch image
> and should retain that extension when copied into the platforms/android directory.
>
> Currently the file will be renamed to screen.png when it should be screen.9.png.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dpogue/cordova-lib android-resources
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/97.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #97
----
commit 0cbb047f37ca275c07b8ef033807263fd580c571
Author: sgrebnov <v-...@microsoft.com>
Date: 2014-09-22T18:13:57Z
CB-7607 Add xxhdpi and xxxhdpi support to Android Cordova
commit e1c9537d5d1640981b0cb1e56de5441db040ea05
Author: Darryl Pogue <dv...@gmail.com>
Date: 2014-10-02T23:10:53Z
CB-7598 Support for 9-patch Android splash images
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: xxhdpi/xxxhdpi and 9-patch splash image ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/97
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: xxhdpi/xxxhdpi and 9-patch splash image ...
Posted by sgrebnov <gi...@git.apache.org>.
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-lib/pull/97#issuecomment-57764369
Reviewed :+1:
Travis error is due to unrelated issue in master branch:
src/cordova/metadata/amazon_fireos_parser.js: line 272, col 31, 'et' is not defined.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org