You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@drill.apache.org by Parth Chandra <pc...@maprtech.com> on 2014/08/29 08:37:55 UTC

Review Request 25183: Parquet Complex read/write does not handle repeated scalar values correctly

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25183/
-----------------------------------------------------------

Review request for drill.


Repository: drill-git


Description
-------

Writer throws exception on trying to write repeated varchar. Also the reader does not recognise a file containg repeated scalar types as a complex type.


Diffs
-----

  exec/java-exec/src/main/codegen/templates/ParquetOutputRecordWriter.java d4b5af5 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetScanBatchCreator.java a453e66 
  exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestParquetWriter.java 0f0743a 
  exec/java-exec/src/test/resources/testRepeatedWrite.json PRE-CREATION 

Diff: https://reviews.apache.org/r/25183/diff/


Testing
-------

Added new test in TestParquetWriter - testComplexRepeated.
Ran all unit tests.


Thanks,

Parth Chandra