You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "eladkal (via GitHub)" <gi...@apache.org> on 2023/06/27 19:43:01 UTC

[GitHub] [airflow] eladkal commented on a diff in pull request #32186: Add deferrable mode for `AthenaOperator`

eladkal commented on code in PR #32186:
URL: https://github.com/apache/airflow/pull/32186#discussion_r1244266130


##########
airflow/providers/amazon/aws/operators/athena.py:
##########
@@ -33,6 +33,9 @@ class AthenaOperator(BaseOperator):
     """
     An operator that submits a presto query to athena.
 
+    Note: if the task is killed while it runs, it'll cancel the athena query that was launched,

Review Comment:
   change to `.. note:`
   
   Similar to https://github.com/apache/airflow/blob/9fa75aaf7a391ebf0e6b6949445c060f6de2ceb9/airflow/operators/bash.py#L80
   
   (for some reason it doesn't allow me to suggest changes)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org