You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by nsuke <gi...@git.apache.org> on 2014/12/07 13:46:43 UTC
[GitHub] thrift pull request: THRIFT-2098 Add support for Qt5+
GitHub user nsuke opened a pull request:
https://github.com/apache/thrift/pull/307
THRIFT-2098 Add support for Qt5+
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nsuke/thrift THRIFT-2098
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/307.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #307
----
commit 8e202a86781b19ad82cbdb4057498c052f8bca90
Author: Nobuaki Sukegawa <ns...@gmail.com>
Date: 2014-12-07T12:45:33Z
THRIFT-2098 Add support for Qt5+
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-2098 Add support for Qt5+
Posted by nsuke <gi...@git.apache.org>.
Github user nsuke closed the pull request at:
https://github.com/apache/thrift/pull/307
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-2098 Add support for Qt5+
Posted by nsuke <gi...@git.apache.org>.
Github user nsuke commented on the pull request:
https://github.com/apache/thrift/pull/307#issuecomment-67672885
The build has been fixed (Travis failure is gcc internal error + make cross instability).
I also added CMake build.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-2098 Add support for Qt5+
Posted by nsuke <gi...@git.apache.org>.
Github user nsuke commented on a diff in the pull request:
https://github.com/apache/thrift/pull/307#discussion_r21424274
--- Diff: lib/cpp/Makefile.am ---
@@ -22,6 +22,9 @@ AUTOMAKE_OPTIONS = subdir-objects
moc_%.cpp: %.h
$(QT_MOC) $(QT_CFLAGS) $< -o $@
+moc__%.cpp: %.h
--- End diff --
I wanted to do it with "moc5_" but some how "5" is ignored and resulted in conflict with Qt4 moc_.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-2098 Add support for Qt5+
Posted by nsuke <gi...@git.apache.org>.
Github user nsuke commented on the pull request:
https://github.com/apache/thrift/pull/307#issuecomment-65941695
Yes, sorry for prematurely pushing the fix.
I'm having difficulty with Ubuntu 12.04 + trusty apt repo with Qt5 (on
travis).
It is specifically caused by "moc" executable installation failure (Failing
to find moc-qt5 and using qt4 version, hence the error).
I'm currently trying to fix it here, reducing to minimal set.
https://travis-ci.org/nsuke/thrift/builds
On Mon, Dec 8, 2014 at 12:45 AM, Roger Meier <no...@github.com>
wrote:
> any idea why the build fails?
> https://travis-ci.org/apache/thrift/jobs/43262266
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/thrift/pull/307#issuecomment-65941392>.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-2098 Add support for Qt5+
Posted by bufferoverflow <gi...@git.apache.org>.
Github user bufferoverflow commented on the pull request:
https://github.com/apache/thrift/pull/307#issuecomment-65941392
any idea why the build fails?
https://travis-ci.org/apache/thrift/jobs/43262266
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-2098 Add support for Qt5+
Posted by nsuke <gi...@git.apache.org>.
Github user nsuke commented on the pull request:
https://github.com/apache/thrift/pull/307#issuecomment-67772599
Obsoleted by this
https://github.com/apache/thrift/pull/335
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-2098 Add support for Qt5+
Posted by nsuke <gi...@git.apache.org>.
Github user nsuke commented on a diff in the pull request:
https://github.com/apache/thrift/pull/307#discussion_r21424261
--- Diff: configure.ac ---
@@ -152,11 +152,26 @@ if test "$with_cpp" = "yes"; then
AC_PATH_PROGS([QT_MOC], [moc-qt4 moc])
have_qt=$success
fi
+
+ AX_THRIFT_LIB(qt5, [Qt5], yes)
+ have_qt5=no
+ qt_reduce_reloc=""
+ if test "$with_qt5" = "yes"; then
+ PKG_CHECK_MODULES([QT5], [Qt5Core >= 5.0, Qt5Network >= 5.0],
+ [have_qt5=yes;qt_reduce_reloc=`$PKG_CONFIG --variable=qt_config Qt5Core | grep "reduce_relocations"`],
--- End diff --
It's to resolve a build error I experienced (with Qt5 only) that said I need -fPIC with "reduce_relocations"-enabled version of Qt
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---