You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2018/03/02 16:07:50 UTC

[GitHub] khos2ow commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script

khos2ow commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script
URL: https://github.com/apache/cloudstack/pull/2433#issuecomment-369966282
 
 
   @rhtyd @rafaelweingartner my goal in this PR was to be able to support
   
   - custom branding in POM version or provide it on the fly on CLI
   - concept of timestamp for SNAPSHOT versions (i.e. development cycles)
   
   in final artifacts (rpm, deb, systemvm-templates) and to achieve this I ended up modifying some files
   
   - `Version.java` for instance to correctly handle `x.y.z.a-brand-[SNAPSHOT|timestamp]`
     - for MS to detect if VR needs to be upgraded
     - shown in `/etc/cloudstack-release`
   - `setnextversion.sh` to add `--no-commit` flag to change the version on the fly (from SNAPSHOT to `timestamp`, if specified) in packaging script to have consistency between deb, rpm versions and ACS version itself (which is read from final jar package version)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services