You are viewing a plain text version of this content. The canonical link for it is here.

Posted to oak-commits@jackrabbit.apache.org by th...@apache.org on 2012/04/12 17:24:20 UTC

svn commit: r1325318 - /jackrabbit/oak/trunk/oak-mk/src/test/java/org/apache/jackrabbit/mk/blobs/AbstractBlobStoreTest.java

Author: thomasm
Date: Thu Apr 12 15:24:20 2012
New Revision: 1325318

URL: http://svn.apache.org/viewvc?rev=1325318&view=rev
Log:
OAK-58 connection leak in test case - fix problem "can not access a member of class org.apache.jackrabbit.mk.blobs.AbstractBlobStoreTest with modifiers "public""

Modified:
    jackrabbit/oak/trunk/oak-mk/src/test/java/org/apache/jackrabbit/mk/blobs/AbstractBlobStoreTest.java

Modified: jackrabbit/oak/trunk/oak-mk/src/test/java/org/apache/jackrabbit/mk/blobs/AbstractBlobStoreTest.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-mk/src/test/java/org/apache/jackrabbit/mk/blobs/AbstractBlobStoreTest.java?rev=1325318&r1=1325317&r2=1325318&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-mk/src/test/java/org/apache/jackrabbit/mk/blobs/AbstractBlobStoreTest.java (original)
+++ jackrabbit/oak/trunk/oak-mk/src/test/java/org/apache/jackrabbit/mk/blobs/AbstractBlobStoreTest.java Thu Apr 12 15:24:20 2012
@@ -38,7 +38,7 @@ import java.util.concurrent.atomic.Atomi
 /**
  * Tests a BlobStore implementation.
  */
-abstract class AbstractBlobStoreTest extends TestCase {
+public abstract class AbstractBlobStoreTest extends TestCase {
 
     protected AbstractBlobStore store;

Re: svn commit: r1325318 - /jackrabbit/oak/trunk/oak-mk/src/test/java/org/apache/jackrabbit/mk/blobs/AbstractBlobStoreTest.java

Posted by Jukka Zitting <ju...@gmail.com>.

Hi,

On Thu, Apr 12, 2012 at 5:43 PM, Thomas Mueller <mu...@adobe.com> wrote:
>>Where did that error come up? AFAICT the BlobStoreTests are all inside
>>the same package which is why I kept the abstract base class
>>package-private.
>
> It was when running the tests within Eclipse.

OK, cool. I was just wondering if I had missed something obvious.

BR,

Jukka Zitting

Re: svn commit: r1325318 - /jackrabbit/oak/trunk/oak-mk/src/test/java/org/apache/jackrabbit/mk/blobs/AbstractBlobStoreTest.java

Posted by Thomas Mueller <mu...@adobe.com>.

Hi,

>Where did that error come up? AFAICT the BlobStoreTests are all inside
>the same package which is why I kept the abstract base class
>package-private.

It was when running the tests within Eclipse.

Regards,
Thomas

Re: svn commit: r1325318 - /jackrabbit/oak/trunk/oak-mk/src/test/java/org/apache/jackrabbit/mk/blobs/AbstractBlobStoreTest.java

Posted by Jukka Zitting <ju...@gmail.com>.

Hi,

On Thu, Apr 12, 2012 at 5:24 PM,  <th...@apache.org> wrote:
> OAK-58 connection leak in test case - fix problem "can not access a member of
> class org.apache.jackrabbit.mk.blobs.AbstractBlobStoreTest with modifiers "public""

Where did that error come up? AFAICT the BlobStoreTests are all inside
the same package which is why I kept the abstract base class
package-private.

BR,

Jukka Zitting