You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by tonycox <gi...@git.apache.org> on 2017/02/13 07:39:18 UTC
[GitHub] flink pull request #3297: [FLINK-5431] Add configurable timePattern for clie...
GitHub user tonycox opened a pull request:
https://github.com/apache/flink/pull/3297
[FLINK-5431] Add configurable timePattern for client akka status
Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful description of your changes.
- [ ] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the JIRA id)
- [ ] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [ ] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tonycox/flink akkaTime
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3297.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3297
----
commit 67f15868bb11b96bbf8bf425bf785d7cc7335a09
Author: tonycox <an...@epam.com>
Date: 2017-02-06T15:46:31Z
[FLINK-5431] Add configurable timePattern for client akka status
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3297: [FLINK-5431] Add configurable timePattern for clie...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/3297#discussion_r101052582
--- Diff: docs/setup/config.md ---
@@ -151,6 +151,8 @@ one of the values specified in `security.kerberos.login.contexts`.
### Other
+- `client.logging.time-pattern`: (DEFAULT: `yyyy-MM-dd'T'HH:mm:ss`) The date time pattern applied to client akctor logger.
--- End diff --
`acktor` -> `actor`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3297: [FLINK-5431] Add configurable timePattern for client akka...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3297
Not sure about this. This seems to implement in Flink what is actually the responsibility of the logger.
How about just updating the client such that there are two loggers configured:
1. The one that there is now (all internal stuff)
2. The one that is used for status updates.
The status logger goes to file and console. You can customize the console logging in the logger config then.
That seems a better separation of concerns, and more generally extensible.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3297: [FLINK-5431] Add configurable timePattern for client akka...
Posted by tonycox <gi...@git.apache.org>.
Github user tonycox commented on the issue:
https://github.com/apache/flink/pull/3297
@zentol What do you think about this PR ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3297: [FLINK-5431] Add configurable timePattern for clie...
Posted by tonycox <gi...@git.apache.org>.
Github user tonycox closed the pull request at:
https://github.com/apache/flink/pull/3297
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3297: [FLINK-5431] Add configurable timePattern for client akka...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3297
@tonycox What do you think about my suggestion? If you agree, could you close this pull request?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---