You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iceberg.apache.org by dw...@apache.org on 2023/04/04 17:37:54 UTC
[iceberg] 04/06: Revert "Spark: Add "Iceberg" prefix to SparkTable name string for SparkUI (#5629)" (#7273)
This is an automated email from the ASF dual-hosted git repository.
dweeks pushed a commit to branch 1.2.x
in repository https://gitbox.apache.org/repos/asf/iceberg.git
commit f09f1e16a3b97869daed44e174ab6a6591d7c90c
Author: Amogh Jahagirdar <ja...@amazon.com>
AuthorDate: Mon Apr 3 15:02:47 2023 -0700
Revert "Spark: Add "Iceberg" prefix to SparkTable name string for SparkUI (#5629)" (#7273)
---
.../main/java/org/apache/iceberg/spark/source/SparkTable.java | 2 +-
.../java/org/apache/iceberg/spark/source/TestSparkTable.java | 10 ----------
2 files changed, 1 insertion(+), 11 deletions(-)
diff --git a/spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/source/SparkTable.java b/spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/source/SparkTable.java
index cd501ccb52..fef2f4540a 100644
--- a/spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/source/SparkTable.java
+++ b/spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/source/SparkTable.java
@@ -163,7 +163,7 @@ public class SparkTable
@Override
public String name() {
- return String.format("Iceberg %s", icebergTable.name());
+ return icebergTable.toString();
}
public Long snapshotId() {
diff --git a/spark/v3.3/spark/src/test/java/org/apache/iceberg/spark/source/TestSparkTable.java b/spark/v3.3/spark/src/test/java/org/apache/iceberg/spark/source/TestSparkTable.java
index 4e4d84e760..616a196872 100644
--- a/spark/v3.3/spark/src/test/java/org/apache/iceberg/spark/source/TestSparkTable.java
+++ b/spark/v3.3/spark/src/test/java/org/apache/iceberg/spark/source/TestSparkTable.java
@@ -57,14 +57,4 @@ public class TestSparkTable extends SparkCatalogTestBase {
Assert.assertNotSame("References must be different", table1, table2);
Assert.assertEquals("Tables must be equivalent", table1, table2);
}
-
- @Test
- public void testTableName() throws NoSuchTableException {
- CatalogManager catalogManager = spark.sessionState().catalogManager();
- TableCatalog catalog = (TableCatalog) catalogManager.catalog(catalogName);
- Identifier identifier = Identifier.of(tableIdent.namespace().levels(), tableIdent.name());
- String actualTableName = catalog.loadTable(identifier).name();
- String expectedTableName = String.format("Iceberg %s.%s", catalogName, tableIdent);
- Assert.assertEquals("Table name mismatched", expectedTableName, actualTableName);
- }
}