You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by shikhar <gi...@git.apache.org> on 2016/02/15 05:45:14 UTC
[GitHub] flink pull request: [FLINK-3399] CountWithTimeoutTrigger
GitHub user shikhar opened a pull request:
https://github.com/apache/flink/pull/1636
[FLINK-3399] CountWithTimeoutTrigger
trigger that fires once the number of elements in a pane reaches the given count or the timeout expires, whichever happens first
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shikhar/flink count-with-timeout-trigger
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1636.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1636
----
commit 72d8c902d42d0709cdf27897ea75dab826fe1aa4
Author: shikhar <sh...@schmizz.net>
Date: 2016-02-15T04:38:50Z
[FLINK-3399] CountWithTimeoutTrigger
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3399] CountWithTimeoutTrigger
Posted by shikhar <gi...@git.apache.org>.
Github user shikhar commented on the pull request:
https://github.com/apache/flink/pull/1636#issuecomment-188874026
Thanks @StephanEwen, @aljoscha noted on the JIRA that it may be better to create a composable mechanism like `Any.of(<count trigger>,<time trigger>)`
Until that exists, I do think this is useful functionality, but let me know if we'd prefer to just have the composable way and I should close this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3399] CountWithTimeoutTrigger
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1636#issuecomment-188874847
I would prefer to just add the compassable way, yes. Sorry that you now already put effort into this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3399] CountWithTimeoutTrigger
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1636#issuecomment-188872638
Sorry for the late response, most people are fixing issues for the 1.0 release candidates.
This actually looks like a nice addition.
+1 for adding a small library/collection of typical triggers and patterns.
Let's merge this into master once the 1.0 release is out, to be released with either 1.1.0 or 1.0.1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3399] CountWithTimeoutTrigger
Posted by shikhar <gi...@git.apache.org>.
Github user shikhar closed the pull request at:
https://github.com/apache/flink/pull/1636
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---