You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by tillrohrmann <gi...@git.apache.org> on 2018/01/25 14:19:06 UTC

[GitHub] flink pull request #5363: [FLINK-8488] [flip6] Fix Dispatcher job recovery b...

GitHub user tillrohrmann opened a pull request:

    https://github.com/apache/flink/pull/5363

    [FLINK-8488] [flip6] Fix Dispatcher job recovery bug

    ## What is the purpose of the change
    
    Instead of only accepting job submissions if the RunningJobRegistry signals
    that the job's JobSchedulingStatus is PENDING, the Dispatcher now also accepts
    if the job's JobSchedulingStatus is RUNNING. Only if the job is marked as
    DONE, it will be rejected.
    
    ## Verifying this change
    
    - Added `DispatcherTest#testJobRecovery`
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes)
      - The S3 file system connector: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not applicable)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tillrohrmann/flink fixFlip6JobRecovery

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5363.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5363
    
----
commit f4b56840a52091984655cd20a8939e6cace92ddf
Author: Till Rohrmann <tr...@...>
Date:   2018-01-25T14:15:57Z

    [FLINK-8488] [flip6] Fix Dispatcher job recovery bug
    
    Instead of only accepting job submissions if the RunningJobRegistry signals
    that the job's JobSchedulingStatus is PENDING, the Dispatcher now also accepts
    if the job's JobSchedulingStatus is RUNNING. Only if the job is marked as
    DONE, it will be rejected.

----


---

[GitHub] flink pull request #5363: [FLINK-8488] [flip6] Fix Dispatcher job recovery b...

Posted by tillrohrmann <gi...@git.apache.org>.

Github user tillrohrmann closed the pull request at:

    https://github.com/apache/flink/pull/5363


---

[GitHub] flink issue #5363: [FLINK-8488] [flip6] Fix Dispatcher job recovery bug

Posted by tillrohrmann <gi...@git.apache.org>.

Github user tillrohrmann commented on the issue:

    https://github.com/apache/flink/pull/5363
  
    Thanks for the review @GJL. Merging this PR.


---