You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "gaurav-narula (via GitHub)" <gi...@apache.org> on 2024/02/08 12:46:30 UTC

Re: [PR] MINOR: set test global timeout as 10 mins [kafka]

gaurav-narula commented on code in PR #15065:
URL: https://github.com/apache/kafka/pull/15065#discussion_r1482924308


##########
clients/src/test/resources/junit-platform.properties:
##########
@@ -13,3 +13,4 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 junit.jupiter.params.displayname.default = "{displayName}.{argumentsWithNames}"
+junit.jupiter.execution.timeout.default = 10 m

Review Comment:
   Note that this sets a timeout of `10m` on the lifecycle methods as well. While I think we should have a timeout on lifecycle methods too, perhaps we can decrease its value to say `5m` (or even lesser if that seems apt)?  WDYT?
   
   Refer the `junit.jupiter.execution.timeout.lifecycle.method.default` prop for more information.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org