You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by audreyso <gi...@git.apache.org> on 2017/06/06 00:39:22 UTC
[GitHub] cordova-lib pull request #561: Cb 12870 - Check that all use cases are caugh...
GitHub user audreyso opened a pull request:
https://github.com/apache/cordova-lib/pull/561
Cb 12870 - Check that all use cases are caught in Api.js
Not ready for review yet, still updating tests. Thanks!
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist
is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
### What does this PR do?
Check that all use cases are caught in Api.js
### What testing has been done on this change?
### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [X] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/audreyso/cordova-lib CB-12870
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/561.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #561
----
commit 5ccbba28764faa675b65d26429e9685c76b98825
Author: Audrey So <au...@apache.org>
Date: 2017-05-31T17:41:22Z
CB-12870 : catch all use cases for getPlatformApiFunc and update tests accordingly
commit f051199236e85a546236891303147a11d0b123ee
Author: Audrey So <au...@apache.org>
Date: 2017-06-03T00:24:32Z
CB-12870 : checks if platformapi.createplatform func exists and throws error if api is not compatible
commit 75c8d8b9bb4c3caecdd518de77a01ba95397aa0a
Author: Audrey So <au...@apache.org>
Date: 2017-06-05T18:47:11Z
CB-12870 : added util tests to check getPlatformApiFunction
commit c8c8e626e698d8c742c40b2f7c8932aa52f880a1
Author: Audrey So <au...@apache.org>
Date: 2017-06-06T00:23:35Z
CB-12870 : removed checkPlatformApiCompatible function and update tests in platforms.spec"
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #561: Cb 12870 - Check that all use cases are caught in Ap...
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-lib/pull/561
# [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/561?src=pr&el=h1) Report
> Merging [#561](https://codecov.io/gh/apache/cordova-lib/pull/561?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-lib/commit/aafe7c773614b09dadcf9efd041a2663d1d7b555?src=pr&el=desc) will **decrease** coverage by `1.77%`.
> The diff coverage is `81.25%`.
[](https://codecov.io/gh/apache/cordova-lib/pull/561?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #561 +/- ##
==========================================
- Coverage 80.12% 78.35% -1.78%
==========================================
Files 57 57
Lines 3960 3964 +4
Branches 832 833 +1
==========================================
- Hits 3173 3106 -67
- Misses 787 858 +71
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-lib/pull/561?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [cordova-lib/src/cordova/util.js](https://codecov.io/gh/apache/cordova-lib/pull/561?src=pr&el=tree#diff-Y29yZG92YS1saWIvc3JjL2NvcmRvdmEvdXRpbC5qcw==) | `96.03% <81.25%> (-0.34%)` | :arrow_down: |
| [cordova-lib/src/platforms/PlatformApiPoly.js](https://codecov.io/gh/apache/cordova-lib/pull/561?src=pr&el=tree#diff-Y29yZG92YS1saWIvc3JjL3BsYXRmb3Jtcy9QbGF0Zm9ybUFwaVBvbHkuanM=) | `71.31% <0%> (-20.16%)` | :arrow_down: |
| [cordova-lib/src/plugman/platforms/common.js](https://codecov.io/gh/apache/cordova-lib/pull/561?src=pr&el=tree#diff-Y29yZG92YS1saWIvc3JjL3BsdWdtYW4vcGxhdGZvcm1zL2NvbW1vbi5qcw==) | `69.47% <0%> (-14.74%)` | :arrow_down: |
| [cordova-lib/src/cordova/metadata/browser\_parser.js](https://codecov.io/gh/apache/cordova-lib/pull/561?src=pr&el=tree#diff-Y29yZG92YS1saWIvc3JjL2NvcmRvdmEvbWV0YWRhdGEvYnJvd3Nlcl9wYXJzZXIuanM=) | `83.72% <0%> (-13.96%)` | :arrow_down: |
| [cordova-lib/src/cordova/platform.js](https://codecov.io/gh/apache/cordova-lib/pull/561?src=pr&el=tree#diff-Y29yZG92YS1saWIvc3JjL2NvcmRvdmEvcGxhdGZvcm0uanM=) | `75.53% <0%> (+0.47%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-lib/pull/561?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/561?src=pr&el=footer). Last update [aafe7c7...e9767d0](https://codecov.io/gh/apache/cordova-lib/pull/561?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request #561: Cb 12870 - Check that all use cases are caugh...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/561
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #561: Cb 12870 - Check that all use cases are caught in Ap...
Posted by audreyso <gi...@git.apache.org>.
Github user audreyso commented on the issue:
https://github.com/apache/cordova-lib/pull/561
@filmaj I rebased this for now. If we change the tests to unit tests, should it be in this PR or in a separate one?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #561: Cb 12870 - Check that all use cases are caught in Ap...
Posted by filmaj <gi...@git.apache.org>.
Github user filmaj commented on the issue:
https://github.com/apache/cordova-lib/pull/561
Your experience going through the integration tests in here is valuable with respect to understanding what code these tests exercise, so armed with that knowledge, I think you have the right context to add unit tests for that code (and instead, delete the integration tests relevant to that code).
As for whether it's in this PR or a separate one, your call. There will probably end up being extraneous commits in this PR. I would probably issue a new PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #561: Cb 12870 - Check that all use cases are caught in Ap...
Posted by filmaj <gi...@git.apache.org>.
Github user filmaj commented on the issue:
https://github.com/apache/cordova-lib/pull/561
Couple things in this one:
1. This will need a rebase with the latest.
2. I wonder if instead of putting more efforts into tweaking the fixtures and integration tests, we put more effort into converting the integration tests into unit tests wherever it makes sense.
Let me know what you think @audreyso.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org