[GitHub] [doris] BiteTheDDDDt commented on a diff in pull request #11041: [Bug] fix bug for function `unix_timestamp`

[GitBox <gi...@apache.org>]

BiteTheDDDDt commented on code in PR #11041:
URL: https://github.com/apache/doris/pull/11041#discussion_r925462542


##########
be/src/vec/functions/function_timestamp.cpp:
##########
@@ -206,7 +206,11 @@ struct UnixTimeStampImpl {
                                const ColumnNumbers& arguments, size_t result,
                                size_t input_rows_count) {
         auto col_result = ColumnVector<Int32>::create();
-        col_result->insert(context->impl()->state()->timestamp_ms() / 1000);
+        col_result->resize(input_rows_count);
+        auto& col_result_data = col_result->get_data();
+        for (int i = 0; i < input_rows_count; i++) {
+            col_result_data[i] = context->impl()->state()->timestamp_ms() / 1000;

Review Comment:
   Maybe we can calculate it once only on out of loop.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org