You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/05/13 21:19:19 UTC
[GitHub] [druid] clintropolis commented on a change in pull request #9856: change default number of segment loading threads
clintropolis commented on a change in pull request #9856:
URL: https://github.com/apache/druid/pull/9856#discussion_r424730444
##########
File path: server/src/main/java/org/apache/druid/segment/loading/SegmentLoaderConfig.java
##########
@@ -50,7 +50,7 @@
private int announceIntervalMillis = 0; // do not background announce
@JsonProperty("numLoadingThreads")
- private int numLoadingThreads = JvmUtils.getRuntimeInfo().getAvailableProcessors();
+ private int numLoadingThreads = Math.min(1, JvmUtils.getRuntimeInfo().getAvailableProcessors() / 6);
Review comment:
Oops, I think this should be `Math.max` so the value isn't always 0 or 1?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org