You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/04/08 15:23:39 UTC

[GitHub] [pulsar] tjiuming commented on a diff in pull request #14723: [Broker] Improve SchemaRegistry logs and metrics

tjiuming commented on code in PR #14723:
URL: https://github.com/apache/pulsar/pull/14723#discussion_r846242956


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java:
##########
@@ -956,6 +956,10 @@ protected void handleSubscribe(final CommandSubscribe subscribe) {
               ? new KeySharedMeta().copyFrom(subscribe.getKeySharedMeta())
               : emptyKeySharedMeta;
 
+
+        log.debug("Topic name = {}, subscription name = {}, schema is {}", topicName, subscriptionName,

Review Comment:
   I think it depends. If there are some params like `JSONUtil.toJsonStr(obj)`, `log.isDebugEnabled()` is required, but there are only original Strings.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org