[jira] [Commented] (TAP5-2735) LocalizationSetter should add "void setLocaleFromRequest(Request)"

["Ben Weidig (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TAP5-2735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17587062#comment-17587062 ] 

Ben Weidig commented on TAP5-2735:
----------------------------------

During implementation is became clear that the name should be "setNonPersistentLocaleFromRequest" because it just delegates to "setNonPeristentLocaleFromLocaleName".

> LocalizationSetter should add "void setLocaleFromRequest(Request)"
> ------------------------------------------------------------------
>
>                 Key: TAP5-2735
>                 URL: https://issues.apache.org/jira/browse/TAP5-2735
>             Project: Tapestry 5
>          Issue Type: Improvement
>          Components: tapestry-core
>    Affects Versions: 5.8.2
>            Reporter: Ben Weidig
>            Assignee: Ben Weidig
>            Priority: Minor
>
> The LocalizationSetter is responsible for setting the correct Locale and provides an excellent extension/override point if you want to affect that, like we do in a multi-tenant/multi-language application.
> But component events fallback to the Request Locale if no other is available, which leads to wrong Locale detection in our case.
> The responsible void setLocaleFromRequest(Request) is a private method in org.apache.tapestry5.internal.services.ComponentEventLinkEncoderImpl which is not correct IMO.
> I propose moving the related code to the LocalizationSetter, so all Locale-related code is in a single interface and therefore modifiable by contributing a custom one.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)