You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/04/05 01:58:55 UTC

[GitHub] [airflow] kaxil opened a new pull request #8151: BugFix: Fix writing Dag Code for Serialized DAGs

kaxil opened a new pull request #8151: BugFix: Fix writing Dag Code for Serialized DAGs
URL: https://github.com/apache/airflow/pull/8151
 
 
   With `store_dag_code` enabled scheduler throws the following error:
   
   ```
   Traceback (most recent call last):
     File "/usr/local/lib/python3.7/multiprocessing/process.py", line
   297, in _bootstrap
       self.run()
     File "/usr/local/lib/python3.7/multiprocessing/process.py", line 99, in run
       self._target(*self._args, **self._kwargs)
     File "/usr/local/lib/python3.7/site-packages/airflow/jobs/scheduler_job.py",
   line 158, in _run_file_processor
       pickle_dags)
     File "/usr/local/lib/python3.7/site-packages/airflow/utils/db.py",
   line 74, in wrapper
       return func(*args, **kwargs)
     File "/usr/local/lib/python3.7/site-packages/airflow/jobs/scheduler_job.py",
   line 1582, in process_file
       dag.sync_to_db()
     File "/usr/local/lib/python3.7/site-packages/airflow/utils/db.py",
   line 74, in wrapper
       return func(*args, **kwargs)
     File "/usr/local/lib/python3.7/site-packages/airflow/models/dag.py",
   line 1519, in sync_to_db
       DagCode.bulk_sync_to_db([dag.fileloc for dag in orm_dag])
   TypeError: 'DagModel' object is not iterable
   ```
   
   ---
   Make sure to mark the boxes below before creating PR: [x]
   
   - [x] Description above provides context of the change
   - [x] Unit tests coverage for changes (not needed for documentation changes)
   - [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
   - [x] Relevant documentation is updated including usage instructions.
   - [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] kaxil edited a comment on issue #8151: BugFix: Fix writing & deleting Dag Code for Serialized DAGs

Posted by GitBox <gi...@apache.org>.
kaxil edited a comment on issue #8151: BugFix: Fix writing & deleting Dag Code for Serialized DAGs
URL: https://github.com/apache/airflow/pull/8151#issuecomment-609406972
 
 
   @KostyaEsmukov Can you please check now with the patch in this PR. 🤞 All problems should be solved.
   
   I have tested locally and DagCode is successfully saved in the DB and overwritten when a file has changed too

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] kaxil commented on issue #8151: BugFix: Fix writing & deleting Dag Code for Serialized DAGs

Posted by GitBox <gi...@apache.org>.
kaxil commented on issue #8151: BugFix: Fix writing & deleting Dag Code for Serialized DAGs
URL: https://github.com/apache/airflow/pull/8151#issuecomment-609406972
 
 
   @KostyaEsmukov Can you please check now with the patch in this PR. 🤞 All problems should be solved

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] KostyaEsmukov commented on issue #8151: BugFix: Fix writing & deleting Dag Code for Serialized DAGs

Posted by GitBox <gi...@apache.org>.
KostyaEsmukov commented on issue #8151: BugFix: Fix writing & deleting Dag Code for Serialized DAGs
URL: https://github.com/apache/airflow/pull/8151#issuecomment-609438272
 
 
   @kaxil Thanks for the fix! The scheduler errors are gone, but on a stateless webserver the code is still not rendered, because, apparently, `DagCode` instance always tries to read the code from a local file during initialization:
   
   ```
   >>> DagCode(dag_orm.fileloc)
   Traceback (most recent call last):
     File "<stdin>", line 1, in <module>
     File "<string>", line 4, in __init__
     File "/usr/local/lib/python3.7/site-packages/sqlalchemy/orm/state.py", line 433, in _initialize_instance
       manager.dispatch.init_failure(self, args, kwargs)
     File "/usr/local/lib/python3.7/site-packages/sqlalchemy/util/langhelpers.py", line 69, in __exit__
       exc_value, with_traceback=exc_tb,
     File "/usr/local/lib/python3.7/site-packages/sqlalchemy/util/compat.py", line 178, in raise_
       raise exception
     File "/usr/local/lib/python3.7/site-packages/sqlalchemy/orm/state.py", line 430, in _initialize_instance
       return manager.original_init(*mixed[1:], **kwargs)
     File "/usr/local/lib/python3.7/site-packages/airflow/models/dagcode.py", line 59, in __init__
       self.source_code = DagCode._read_code(self.fileloc)
     File "/usr/local/lib/python3.7/site-packages/airflow/models/dagcode.py", line 63, in _read_code
       with open_maybe_zipped(fileloc, 'r') as source:
     File "/usr/local/lib/python3.7/site-packages/airflow/utils/file.py", line 102, in open_maybe_zipped
       return io.open(fileloc, mode=mode)
   FileNotFoundError: [Errno 2] No such file or directory: '<...my_dag...>'
   ```
   
   Notice the `_read_code` line.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] kaxil commented on issue #8151: BugFix: Fix writing & deleting Dag Code for Serialized DAGs

Posted by GitBox <gi...@apache.org>.
kaxil commented on issue #8151: BugFix: Fix writing & deleting Dag Code for Serialized DAGs
URL: https://github.com/apache/airflow/pull/8151#issuecomment-609439815
 
 
   
   > @kaxil Thanks for the fix! The scheduler errors are gone, but on a stateless webserver the code is still not rendered, because, apparently, `DagCode` instance always tries to read the code from a local file during initialization:
   > 
   > ```
   > >>> DagCode(dag_orm.fileloc)
   > Traceback (most recent call last):
   >   File "<stdin>", line 1, in <module>
   >   File "<string>", line 4, in __init__
   >   File "/usr/local/lib/python3.7/site-packages/sqlalchemy/orm/state.py", line 433, in _initialize_instance
   >     manager.dispatch.init_failure(self, args, kwargs)
   >   File "/usr/local/lib/python3.7/site-packages/sqlalchemy/util/langhelpers.py", line 69, in __exit__
   >     exc_value, with_traceback=exc_tb,
   >   File "/usr/local/lib/python3.7/site-packages/sqlalchemy/util/compat.py", line 178, in raise_
   >     raise exception
   >   File "/usr/local/lib/python3.7/site-packages/sqlalchemy/orm/state.py", line 430, in _initialize_instance
   >     return manager.original_init(*mixed[1:], **kwargs)
   >   File "/usr/local/lib/python3.7/site-packages/airflow/models/dagcode.py", line 59, in __init__
   >     self.source_code = DagCode._read_code(self.fileloc)
   >   File "/usr/local/lib/python3.7/site-packages/airflow/models/dagcode.py", line 63, in _read_code
   >     with open_maybe_zipped(fileloc, 'r') as source:
   >   File "/usr/local/lib/python3.7/site-packages/airflow/utils/file.py", line 102, in open_maybe_zipped
   >     return io.open(fileloc, mode=mode)
   > FileNotFoundError: [Errno 2] No such file or directory: '<...my_dag...>'
   > ```
   > 
   > Notice the `_read_code` line.
   
   Are you on Airflow Slack (https://apache-airflow-slack.herokuapp.com/), would you mind signing up if you are not so that we can check this together :)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io commented on issue #8151: BugFix: Fix writing Dag Code for Serialized DAGs

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #8151: BugFix: Fix writing Dag Code for Serialized DAGs
URL: https://github.com/apache/airflow/pull/8151#issuecomment-609136696
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/8151?src=pr&el=h1) Report
   > Merging [#8151](https://codecov.io/gh/apache/airflow/pull/8151?src=pr&el=desc) into [v1-10-test](https://codecov.io/gh/apache/airflow/commit/f3c49241c1ace6e59b64be6f338fc5cc6a19c516&el=desc) will **decrease** coverage by `53.47%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/8151/graphs/tree.svg?width=650&height=150&src=pr&token=WdLKlKHOAU)](https://codecov.io/gh/apache/airflow/pull/8151?src=pr&el=tree)
   
   ```diff
   @@               Coverage Diff               @@
   ##           v1-10-test    #8151       +/-   ##
   ===============================================
   - Coverage       81.81%   28.34%   -53.48%     
   ===============================================
     Files             541      541               
     Lines           37178    37178               
   ===============================================
   - Hits            30417    10537    -19880     
   - Misses           6761    26641    +19880     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/8151?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/models/dag.py](https://codecov.io/gh/apache/airflow/pull/8151/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvZGFnLnB5) | `43.35% <0.00%> (-48.96%)` | :arrow_down: |
   | [airflow/www/forms.py](https://codecov.io/gh/apache/airflow/pull/8151/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvZm9ybXMucHk=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [airflow/www\_rbac/forms.py](https://codecov.io/gh/apache/airflow/pull/8151/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3dfcmJhYy9mb3Jtcy5weQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [airflow/www/gunicorn\_config.py](https://codecov.io/gh/apache/airflow/pull/8151/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvZ3VuaWNvcm5fY29uZmlnLnB5) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [airflow/www\_rbac/blueprints.py](https://codecov.io/gh/apache/airflow/pull/8151/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3dfcmJhYy9ibHVlcHJpbnRzLnB5) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [airflow/operators/mysql\_to\_hive.py](https://codecov.io/gh/apache/airflow/pull/8151/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvbXlzcWxfdG9faGl2ZS5weQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [airflow/operators/mysql\_operator.py](https://codecov.io/gh/apache/airflow/pull/8151/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvbXlzcWxfb3BlcmF0b3IucHk=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [airflow/operators/sqlite\_operator.py](https://codecov.io/gh/apache/airflow/pull/8151/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvc3FsaXRlX29wZXJhdG9yLnB5) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [airflow/operators/generic\_transfer.py](https://codecov.io/gh/apache/airflow/pull/8151/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvZ2VuZXJpY190cmFuc2Zlci5weQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [airflow/operators/postgres\_operator.py](https://codecov.io/gh/apache/airflow/pull/8151/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvcG9zdGdyZXNfb3BlcmF0b3IucHk=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [433 more](https://codecov.io/gh/apache/airflow/pull/8151/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/8151?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/8151?src=pr&el=footer). Last update [f3c4924...cbac1a1](https://codecov.io/gh/apache/airflow/pull/8151?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] potiuk commented on issue #8151: BugFix: Fix writing Dag Code for Serialized DAGs

Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #8151: BugFix: Fix writing Dag Code for Serialized DAGs
URL: https://github.com/apache/airflow/pull/8151#issuecomment-609393788
 
 
   > Tests have passed, failing tests is for Generating requirements.txt and is unrelated
   
   Yep. Rebase should help with that.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] KostyaEsmukov commented on issue #8151: BugFix: Fix writing Dag Code for Serialized DAGs

Posted by GitBox <gi...@apache.org>.
KostyaEsmukov commented on issue #8151: BugFix: Fix writing Dag Code for Serialized DAGs
URL: https://github.com/apache/airflow/pull/8151#issuecomment-609383849
 
 
   @kaxil Thank you for the patch! I've applied it on my installation, and the `dag_code` table filled with rows.
   
   However, new errors appeared in scheduler:
   
   ```
   Process DagFileProcessor35-Process:
   Traceback (most recent call last):
     File "/usr/local/lib/python3.7/multiprocessing/process.py", line 297, in _bootstrap
       self.run()
     File "/usr/local/lib/python3.7/multiprocessing/process.py", line 99, in run
       self._target(*self._args, **self._kwargs)
     File "/usr/local/lib/python3.7/site-packages/airflow/jobs/scheduler_job.py", line 158, in _run_file_processor
       pickle_dags)
     File "/usr/local/lib/python3.7/site-packages/airflow/utils/db.py", line 74, in wrapper
       return func(*args, **kwargs)
     File "/usr/local/lib/python3.7/site-packages/airflow/jobs/scheduler_job.py", line 1582, in process_file
       dag.sync_to_db()
     File "/usr/local/lib/python3.7/site-packages/airflow/utils/db.py", line 74, in wrapper
       return func(*args, **kwargs)
     File "/usr/local/lib/python3.7/site-packages/airflow/models/dag.py", line 1519, in sync_to_db
       DagCode.bulk_sync_to_db([orm_dag.fileloc], session=session)
     File "/usr/local/lib/python3.7/site-packages/airflow/utils/db.py", line 70, in wrapper
       return func(*args, **kwargs)
     File "/usr/local/lib/python3.7/site-packages/airflow/models/dagcode.py", line 131, in bulk_sync_to_db
       orm_dag_code.last_updated = timezone.utcnow()
   UnboundLocalError: local variable 'orm_dag_code' referenced before assignment
   ```
   
   and
   
   ```
   Traceback (most recent call last):
     File "/usr/local/lib/python3.7/multiprocessing/process.py", line 297, in _bootstrap
       self.run()
     File "/usr/local/lib/python3.7/multiprocessing/process.py", line 99, in run
       self._target(*self._args, **self._kwargs)
     File "/usr/local/lib/python3.7/site-packages/airflow/utils/dag_processing.py", line 624, in _run_processor_manager
       processor_manager.start()
     File "/usr/local/lib/python3.7/site-packages/airflow/utils/dag_processing.py", line 856, in start
       self._refresh_dag_dir()
     File "/usr/local/lib/python3.7/site-packages/airflow/utils/dag_processing.py", line 928, in _refresh_dag_dir
       DagCode.remove_deleted_code(self._file_paths)
     File "/usr/local/lib/python3.7/site-packages/airflow/utils/db.py", line 74, in wrapper
       return func(*args, **kwargs)
     File "/usr/local/lib/python3.7/site-packages/airflow/models/dagcode.py", line 151, in remove_deleted_code
       cls.fileloc.notin_(alive_dag_filelocs))).delete())
     File "/usr/local/lib/python3.7/site-packages/sqlalchemy/orm/query.py", line 3789, in delete
       delete_op.exec_()
     File "/usr/local/lib/python3.7/site-packages/sqlalchemy/orm/persistence.py", line 1696, in exec_
       self._do_pre_synchronize()
     File "/usr/local/lib/python3.7/site-packages/sqlalchemy/orm/persistence.py", line 1778, in _do_pre_synchronize
       from_=err,
     File "/usr/local/lib/python3.7/site-packages/sqlalchemy/util/compat.py", line 178, in raise_
       raise exception
   sqlalchemy.exc.InvalidRequestError: Could not evaluate current criteria in Python: "Cannot evaluate clauselist with operator <function comma_op at 0x7f14acf61440>".
    Specify 'fetch' or False for the synchronize_session parameter.
   ```
   
   Do these look like related bugs?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] kaxil merged pull request #8151: BugFix: Fix writing & deleting Dag Code for Serialized DAGs

Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #8151: BugFix: Fix writing & deleting Dag Code for Serialized DAGs
URL: https://github.com/apache/airflow/pull/8151
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #8151: BugFix: Fix writing & deleting Dag Code for Serialized DAGs

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #8151: BugFix: Fix writing & deleting Dag Code for Serialized DAGs
URL: https://github.com/apache/airflow/pull/8151#issuecomment-609136696
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/8151?src=pr&el=h1) Report
   > Merging [#8151](https://codecov.io/gh/apache/airflow/pull/8151?src=pr&el=desc) into [v1-10-test](https://codecov.io/gh/apache/airflow/commit/f3c49241c1ace6e59b64be6f338fc5cc6a19c516&el=desc) will **decrease** coverage by `0.51%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/8151/graphs/tree.svg?width=650&height=150&src=pr&token=WdLKlKHOAU)](https://codecov.io/gh/apache/airflow/pull/8151?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff               @@
   ##           v1-10-test    #8151      +/-   ##
   ==============================================
   - Coverage       81.81%   81.29%   -0.52%     
   ==============================================
     Files             541      541              
     Lines           37178    37178              
   ==============================================
   - Hits            30417    30225     -192     
   - Misses           6761     6953     +192     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/8151?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/models/dagcode.py](https://codecov.io/gh/apache/airflow/pull/8151/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvZGFnY29kZS5weQ==) | `92.13% <ø> (ø)` | |
   | [airflow/models/dag.py](https://codecov.io/gh/apache/airflow/pull/8151/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvZGFnLnB5) | `92.44% <100.00%> (+0.13%)` | :arrow_up: |
   | [airflow/operators/postgres\_operator.py](https://codecov.io/gh/apache/airflow/pull/8151/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvcG9zdGdyZXNfb3BlcmF0b3IucHk=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [airflow/contrib/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/8151/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2t1YmVybmV0ZXMvdm9sdW1lX21vdW50LnB5) | `33.33% <0.00%> (-66.67%)` | :arrow_down: |
   | [airflow/contrib/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/8151/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2t1YmVybmV0ZXMvdm9sdW1lLnB5) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
   | [airflow/contrib/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/8151/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2t1YmVybmV0ZXMvcG9kX2xhdW5jaGVyLnB5) | `45.11% <0.00%> (-47.37%)` | :arrow_down: |
   | [airflow/contrib/kubernetes/pod\_generator.py](https://codecov.io/gh/apache/airflow/pull/8151/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2t1YmVybmV0ZXMvcG9kX2dlbmVyYXRvci5weQ==) | `42.50% <0.00%> (-45.00%)` | :arrow_down: |
   | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/8151/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `56.84% <0.00%> (-40.01%)` | :arrow_down: |
   | [...flow/contrib/operators/postgres\_to\_gcs\_operator.py](https://codecov.io/gh/apache/airflow/pull/8151/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9wb3N0Z3Jlc190b19nY3Nfb3BlcmF0b3IucHk=) | `51.51% <0.00%> (-36.37%)` | :arrow_down: |
   | [airflow/contrib/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/8151/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2t1YmVybmV0ZXMvcmVmcmVzaF9jb25maWcucHk=) | `50.98% <0.00%> (-23.53%)` | :arrow_down: |
   | ... and [8 more](https://codecov.io/gh/apache/airflow/pull/8151/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/8151?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/8151?src=pr&el=footer). Last update [f3c4924...a87f1b3](https://codecov.io/gh/apache/airflow/pull/8151?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] kaxil commented on issue #8151: BugFix: Fix writing Dag Code for Serialized DAGs

Posted by GitBox <gi...@apache.org>.
kaxil commented on issue #8151: BugFix: Fix writing Dag Code for Serialized DAGs
URL: https://github.com/apache/airflow/pull/8151#issuecomment-609194353
 
 
   Tests have passed, failing tests is for Generating requirements.txt and is unrelated

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services