You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@unomi.apache.org by GitBox <gi...@apache.org> on 2020/04/01 11:34:11 UTC
[GitHub] [unomi] ashibest1 opened a new pull request #144: Apache unomi 296
ashibest1 opened a new pull request #144: Apache unomi 296
URL: https://github.com/apache/unomi/pull/144
A new module[unomi-graphql-playground] named Playground has been created.
Playground has two sub-models 1. karaf-kar[unomi-graphql-playground-karaf-kar] 2. wab[unomi-graphql-playground-wab]
A few changes have been made to the Pom.xml file of the kar[unomi-kar] module.
A few changes have been made to the feature.xml file of the kar[unomi-kar] module
A few changes have been made to the pom.xml file of the package[unomi] module [APACHE-UNOMI-296]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [unomi] ashibest1 commented on a change in pull request #144:
Apache unomi 296
Posted by GitBox <gi...@apache.org>.
ashibest1 commented on a change in pull request #144: Apache unomi 296
URL: https://github.com/apache/unomi/pull/144#discussion_r410018760
##########
File path: playground/wab/pom.xml
##########
@@ -0,0 +1,118 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <parent>
+ <artifactId>unomi-graphql-playground</artifactId>
+ <groupId>org.apache.unomi</groupId>
+ <version>1.5.0-SNAPSHOT</version>
+ </parent>
+ <modelVersion>4.0.0</modelVersion>
+
+ <artifactId>unomi-graphql-playground-wab</artifactId>
+ <name>Apache Unomi :: Extension :: GraphQL Playground :: Wab</name>
+ <description>This is a simple Apache Unomi plugin.</description>
+ <packaging>bundle</packaging>
+
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.unomi</groupId>
+ <artifactId>unomi-api</artifactId>
+ <version>${project.version}</version>
+ <scope>provided</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.unomi</groupId>
+ <artifactId>unomi-persistence-spi</artifactId>
+ <version>${project.version}</version>
+ <scope>provided</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.httpcomponents</groupId>
+ <artifactId>httpclient-osgi</artifactId>
+ <scope>provided</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.httpcomponents</groupId>
+ <artifactId>httpcore-osgi</artifactId>
+ <scope>provided</scope>
+ </dependency>
+ <dependency>
+ <groupId>com.fasterxml.jackson.core</groupId>
+ <artifactId>jackson-databind</artifactId>
+ <scope>provided</scope>
+ </dependency>
+ <dependency>
+ <groupId>com.fasterxml.jackson.dataformat</groupId>
+ <artifactId>jackson-dataformat-yaml</artifactId>
+ <version>${version.jackson.core}</version>
+ </dependency>
+ <dependency>
+ <groupId>com.fasterxml.jackson.core</groupId>
+ <artifactId>jackson-annotations</artifactId>
+ <scope>provided</scope>
+ </dependency>
+ <dependency>
+ <groupId>com.fasterxml.jackson.core</groupId>
+ <artifactId>jackson-core</artifactId>
+ <scope>provided</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.ops4j.pax.web</groupId>
+ <artifactId>pax-web-api</artifactId>
+ <scope>provided</scope>
+ </dependency>
+ </dependencies>
+
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.felix</groupId>
+ <artifactId>maven-bundle-plugin</artifactId>
+ <extensions>true</extensions>
+ <configuration>
+ <instructions>
+ <_wab>src/main/webapp</_wab>
+ <Embed-Dependency>*;scope=compile|runtime</Embed-Dependency>
+ <Embed-Directory>WEB-INF/lib</Embed-Directory>
+ <Import-Package>
+ *
+ </Import-Package>
+ <Web-ContextPath>/graphql/playground</Web-ContextPath>
+ </instructions>
+ </configuration>
+ </plugin>
+
+ <plugin>
+ <groupId>org.codehaus.mojo</groupId>
+ <artifactId>build-helper-maven-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>attach-artifacts</id>
+ <phase>package</phase>
+ <goals>
+ <goal>attach-artifact</goal>
+ </goals>
+ <configuration>
+ <artifacts>
+ <artifact>
+ <file>
+ src/main/resources/org.apache.unomi.playground.web.cfg
Review comment:
Resolve this problem
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [unomi] ashibest1 commented on a change in pull request #144:
Apache unomi 296
Posted by GitBox <gi...@apache.org>.
ashibest1 commented on a change in pull request #144: Apache unomi 296
URL: https://github.com/apache/unomi/pull/144#discussion_r410018501
##########
File path: package/pom.xml
##########
@@ -172,6 +180,17 @@
</outputDirectory>
<destFileName>org.apache.unomi.web.cfg</destFileName>
</artifactItem>
+ <artifactItem>
+ <groupId>org.apache.unomi</groupId>
+ <artifactId>unomi-graphql-playground-wab</artifactId>
+ <version>${project.version}</version>
+ <classifier>unomiplaygroundcfg</classifier>
Review comment:
Resolve this problem
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [unomi] ashibest1 commented on a change in pull request #144:
Apache unomi 296
Posted by GitBox <gi...@apache.org>.
ashibest1 commented on a change in pull request #144: Apache unomi 296
URL: https://github.com/apache/unomi/pull/144#discussion_r410018661
##########
File path: playground/wab/pom.xml
##########
@@ -0,0 +1,118 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <parent>
+ <artifactId>unomi-graphql-playground</artifactId>
+ <groupId>org.apache.unomi</groupId>
+ <version>1.5.0-SNAPSHOT</version>
+ </parent>
+ <modelVersion>4.0.0</modelVersion>
+
+ <artifactId>unomi-graphql-playground-wab</artifactId>
+ <name>Apache Unomi :: Extension :: GraphQL Playground :: Wab</name>
+ <description>This is a simple Apache Unomi plugin.</description>
+ <packaging>bundle</packaging>
+
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.unomi</groupId>
Review comment:
Resolve this problem
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [unomi] sergehuber commented on issue #144: Apache unomi 296
Posted by GitBox <gi...@apache.org>.
sergehuber commented on issue #144: Apache unomi 296
URL: https://github.com/apache/unomi/pull/144#issuecomment-614604841
I also forgot to mention that you copied a lot of files from another modules that don't seem useful (like blueprint.xml) and it would be best to get rid of them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [unomi] ashibest1 commented on a change in pull request #144:
Apache unomi 296
Posted by GitBox <gi...@apache.org>.
ashibest1 commented on a change in pull request #144: Apache unomi 296
URL: https://github.com/apache/unomi/pull/144#discussion_r410018875
##########
File path: playground/wab/src/main/resources/OSGI-INF.blueprint/blueprint.xml
##########
@@ -0,0 +1,106 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one or more
+ ~ contributor license agreements. See the NOTICE file distributed with
+ ~ this work for additional information regarding copyright ownership.
+ ~ The ASF licenses this file to You under the Apache License, Version 2.0
+ ~ (the "License"); you may not use this file except in compliance with
+ ~ the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing, software
+ ~ distributed under the License is distributed on an "AS IS" BASIS,
+ ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ ~ See the License for the specific language governing permissions and
+ ~ limitations under the License.
+ -->
+
+<blueprint xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
Review comment:
Resolve this problem
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [unomi] sergehuber commented on issue #144: Apache unomi 296
Posted by GitBox <gi...@apache.org>.
sergehuber commented on issue #144: Apache unomi 296
URL: https://github.com/apache/unomi/pull/144#issuecomment-614604615
Thanks for the changes, I would still like to integrate the frontend-maven-plugin to avoid copying all the Javascript files into the project. Are you familiar with it ? You can simply use a package.json file at the root of your project and then have it executed like this:
<plugin>
<groupId>com.github.eirslett</groupId>
<artifactId>frontend-maven-plugin</artifactId>
<version>1.8.0</version>
<executions>
<execution>
<id>npm install node and yarn</id>
<phase>generate-resources</phase>
<goals>
<goal>install-node-and-yarn</goal>
</goals>
<configuration>
<nodeVersion>v11.11.0</nodeVersion>
<yarnVersion>v1.19.1</yarnVersion>
</configuration>
</execution>
<execution>
<id>yarn install</id>
<phase>generate-resources</phase>
<goals>
<goal>yarn</goal>
</goals>
</execution>
<execution>
<id>yarn post-install</id>
<phase>generate-resources</phase>
<goals>
<goal>yarn</goal>
</goals>
<configuration>
<arguments>${yarn.arguments}</arguments>
</configuration>
</execution>
</executions>
</plugin>
This way you could use yarn add graphql-playground-react and set it up as needed. What do you think ?
Also did you see that GraphQL Playground and GraphiQL will be merging. It doesn't change anything right now but it might be something we want to stay on top of.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
Re: [GitHub] [unomi] sergehuber commented on issue #144: Apache unomi 296
Posted by Ashish Mittal <as...@mattea.io>.
Hello,
I am working on frontend-maven-plugin if i need any help so i will
definitely mail you
On Fri, 17 Apr 2020 at 18:22, GitBox <gi...@apache.org> wrote:
> sergehuber commented on issue #144: Apache unomi 296
> URL: https://github.com/apache/unomi/pull/144#issuecomment-615227334
>
>
> Hello, thanks for the changes. Are you working on the
> frontend-maven-plugin. Do you need some help/clarifications about this?
>
> ----------------------------------------------------------------
> This is an automated message from the Apache Git Service.
> To respond to the message, please log on to GitHub and use the
> URL above to go to the specific comment.
>
> For queries about this service, please contact Infrastructure at:
> users@infra.apache.org
>
>
> With regards,
> Apache Git Services
>
--
Ashish Mittal
Enterprise Software Engineer
MATTEA
The Magic of Personalization
[GitHub] [unomi] sergehuber commented on issue #144: Apache unomi 296
Posted by GitBox <gi...@apache.org>.
sergehuber commented on issue #144: Apache unomi 296
URL: https://github.com/apache/unomi/pull/144#issuecomment-615227334
Hello, thanks for the changes. Are you working on the frontend-maven-plugin. Do you need some help/clarifications about this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [unomi] ashibest1 commented on a change in pull request #144:
Apache unomi 296
Posted by GitBox <gi...@apache.org>.
ashibest1 commented on a change in pull request #144: Apache unomi 296
URL: https://github.com/apache/unomi/pull/144#discussion_r410018959
##########
File path: playground/wab/src/main/resources/org.apache.unomi.playground.web.cfg
##########
@@ -0,0 +1,9 @@
+# Configure here the domain to use the for cookies setup by the Apache Unomi context servlet
Review comment:
Resolve this problem
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services