[jira] [Resolved] (ARTEMIS-996) Simplify and deduplicate lookupHome(path) in artemis-maven-plugin

["Justin Bertram (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/ARTEMIS-996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Justin Bertram resolved ARTEMIS-996.
------------------------------------
       Resolution: Fixed
    Fix Version/s: 2.0.0

> Simplify and deduplicate lookupHome(path) in artemis-maven-plugin
> -----------------------------------------------------------------
>
>                 Key: ARTEMIS-996
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-996
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>          Components: Broker
>    Affects Versions: 2.0.0
>            Reporter: Jiri Danek
>            Priority: Trivial
>             Fix For: 2.0.0
>
>
> ArtemisCLIPlugin.java and ArtemisCreatePlugin.java in artemis-maven-plugin both contain the following code
> {noformat}
>  85      Path binFolder = path.resolve("bin");
>  86
>  87      if (binFolder == null && Files.exists(binFolder, LinkOption.NOFOLLOW_LINKS)) {
>  88         return false;
>  89      }
> {noformat}
> Check for null is unnecessary, because Path#resolve never returns null, and also the condition in if does not make any sense.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)