You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2022/03/09 20:34:41 UTC

[GitHub] [accumulo] dlmarion commented on a change in pull request #2558: Specify when return values are unused

dlmarion commented on a change in pull request #2558:
URL: https://github.com/apache/accumulo/pull/2558#discussion_r823066645



##########
File path: core/src/main/java/org/apache/accumulo/core/clientImpl/ThriftTransportKey.java
##########
@@ -91,7 +91,7 @@ public boolean equals(Object o) {
   }
 
   public final void precomputeHashCode() {
-    hashCode();
+    var unusedRetVal = hashCode();

Review comment:
       seems like in this case you could compute the `hash` in the ctor and get rid of this method




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org