You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/02/13 01:45:51 UTC

[GitHub] [beam] KevinGG commented on a change in pull request #13944: [BEAM-10708] Support SqlTransform in container

KevinGG commented on a change in pull request #13944:
URL: https://github.com/apache/beam/pull/13944#discussion_r575601177



##########
File path: sdks/python/apache_beam/runners/portability/fn_api_runner/worker_handlers.py
##########
@@ -737,11 +738,15 @@ def __init__(self,
 
   def host_from_worker(self):
     # type: () -> str
-    if sys.platform == "darwin":
+    if sys.platform == 'darwin':
       # See https://docs.docker.com/docker-for-mac/networking/
       return 'host.docker.internal'
-    else:
-      return super(DockerSdkWorkerHandler, self).host_from_worker()
+    if sys.platform != 'win32' and is_in_notebook():

Review comment:
       The purpose is to only deal with linux-like system, so I could change this to sys.platform == 'linux' if we want to further limit the platform that need this change.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org