[GitHub] [spark] fhygh commented on a diff in pull request #34900: [SPARK-37643][SQL] when charVarcharAsString is true, char datatype partition table query incorrect

[GitBox <gi...@apache.org>]

fhygh commented on code in PR #34900:
URL: https://github.com/apache/spark/pull/34900#discussion_r844833168


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala:
##########
@@ -4082,18 +4082,21 @@ object ApplyCharTypePadding extends Rule[LogicalPlan] {
 
         // String literal is treated as char type when it's compared to a char type column.
         // We should pad the shorter one to the longer length.
-        case b @ BinaryComparison(e @ AttrOrOuterRef(attr), lit) if lit.foldable =>
+        case b @ BinaryComparison(e @ AttrOrOuterRef(attr), lit)

Review Comment:
   sorry, maybe my description is not very precise, the problem exists for char type column predicate, it is irrelevant to whether the partition is used.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org