[GitHub] [spark] MaxGekk commented on a diff in pull request #37804: [SPARK-40352][SQL] Add function aliases: len, datepart, dateadd, date_diff and curdate

[GitBox <gi...@apache.org>]

MaxGekk commented on code in PR #37804:
URL: https://github.com/apache/spark/pull/37804#discussion_r963436750


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala:
##########
@@ -598,7 +598,7 @@ object FunctionRegistry {
     // datetime functions
     expression[AddMonths]("add_months"),
     expression[CurrentDate]("current_date"),
-    expression[CurrentDate]("curdate", setAlias = true, Some("3.4.0")),
+    expressionBuilder("curdate", CurDateExpressionBuilder, setAlias = true),

Review Comment:
   The example of the expression: `CURDATE` without braces. Support of `CURRENT_DATE` is embedded in the syntax rules.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org