[GitHub] [flink] dawidwys commented on pull request #13343: [FLINK-19083] Remove deprecated DataStream#split

[GitBox <gi...@apache.org>]

dawidwys commented on pull request #13343:
URL: https://github.com/apache/flink/pull/13343#issuecomment-688848011


   As for the question if it was easy to use side outputs instead of split/select. Personally I found it rather straightforward. In the IterateExample I even find the code much simpler, as the splitting is coupled within the mapper which looks more natural to me. There are two issues I found that could've been a bit easier:
   
   1. It would be nice if we could have side outputs e.g. from RichMapFunction. I had to replace `MapFunction` with `ProcessFunction`
   2. I also found a comment in the `OutputTag` a bit misleading: `It is also not possible to use generic type variables with OutputTags, such as 'Tuple2<A, B>'` It is actually possible to do, you just need to create the OutputTag as an anonymous class. I will change the comment in the exception.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org