You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "potiuk (via GitHub)" <gi...@apache.org> on 2023/12/17 17:01:05 UTC

[PR] Fix few caveats in provider rlease process [airflow]

potiuk opened a new pull request, #36264:
URL: https://github.com/apache/airflow/pull/36264

   There were few small problems in release process:
   
   1) When the SVN directories were in symbolically linked directories, svn
      got into locked directory status
   2) Cleaning old relases failed to find the files in current directory,
      because breeze changes working directory before running and the `.`
      directory was really `airflow` repository, thus no released artifacts
      could be found.
   3) When the old releases contained `_` rather thatn `-` (as it was
      in the bdist_wheel prepared packages) then we failed to delet the
      files because the file names for them were constructed from the
      normalized file names (with `-`).
   
   This PR fixes those problems:
   
   1) `VAR=$(pwd -P)` is used in order to resolve potentially symbolically
      linked urrent working directory and `cd ${VAR}` is used to switch dir
      to them
   2) The same `$(pwd -P)` is used to pass the directory to the
      clean-old-provider-artifacts command to avoid interpreting `.` as
      "AIRFLOW_ROOT" directory.
   3) Filen name is stored in FileVersion and used to run actual `svn rm`
      command - this way the right file name will be used, regardless from
      normalization of the package names.
   
   <!--
    Licensed to the Apache Software Foundation (ASF) under one
    or more contributor license agreements.  See the NOTICE file
    distributed with this work for additional information
    regarding copyright ownership.  The ASF licenses this file
    to you under the Apache License, Version 2.0 (the
    "License"); you may not use this file except in compliance
    with the License.  You may obtain a copy of the License at
   
      http://www.apache.org/licenses/LICENSE-2.0
   
    Unless required by applicable law or agreed to in writing,
    software distributed under the License is distributed on an
    "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    KIND, either express or implied.  See the License for the
    specific language governing permissions and limitations
    under the License.
    -->
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of an existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   
   
   <!-- Please keep an empty line above the dashes. -->
   ---
   **^ Add meaningful description above**
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix few caveats in provider release process [airflow]

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #36264:
URL: https://github.com/apache/airflow/pull/36264


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org