You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Harsh J (Created) (JIRA)" <ji...@apache.org> on 2011/09/29 07:22:46 UTC
[jira] [Created] (HBASE-4510) HDFS-1620 related changes downstream
(For compiling with HDFS 0.23+)
HDFS-1620 related changes downstream (For compiling with HDFS 0.23+)
--------------------------------------------------------------------
Key: HBASE-4510
URL: https://issues.apache.org/jira/browse/HBASE-4510
Project: HBase
Issue Type: Task
Affects Versions: 0.94.0
Reporter: Harsh J
Priority: Blocker
HBase isn't seemingly compiling anymore on 0.23 after the HDFS-1620 naming refactorings were carried out.
Two solutions:
* We use new classnames. This breaks HBase's backward compatibility with older Hadoop releases (is that a concern with future releases?)
* HBase gets its own sets of constants as the upstream one is not marked for public usage. This needs a little more maintenance on HBases' side.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4510) Check and workaround usage of
internal HDFS APIs in HBase
Posted by "Harsh J (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Harsh J updated HBASE-4510:
---------------------------
Priority: Major (was: Blocker)
Summary: Check and workaround usage of internal HDFS APIs in HBase (was: HDFS-1620 related changes downstream (For compiling with HDFS 0.23+))
Unfortunately my vacation's made me go way off-sync surrounding this issue.
Todd has fixed build for 0.23 via HDFS-2412 already, and that patch would be available for 0.23 at least (graceful deprecation being the plan).
We're proposing adding a public 'check' of SafeMode status in HDFS upstream, via HDFS-2413, which HBASE and other projects can then rely on.
Changes made to ticket:
- Changed title to reflect new goal.
- Changed the severity down from blocker as it isn't anymore, after HDFS-2412 went in.
> Check and workaround usage of internal HDFS APIs in HBase
> ---------------------------------------------------------
>
> Key: HBASE-4510
> URL: https://issues.apache.org/jira/browse/HBASE-4510
> Project: HBase
> Issue Type: Task
> Affects Versions: 0.94.0
> Reporter: Harsh J
> Assignee: Harsh J
>
> HBase isn't seemingly compiling anymore on 0.23 after the HDFS-1620 naming refactorings were carried out.
> Two solutions:
> * We use new classnames. This breaks HBase's backward compatibility with older Hadoop releases (is that a concern with future releases?)
> * HBase gets its own sets of constants as the upstream one is not marked for public usage. This needs a little more maintenance on HBases' side.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4510) Check and workaround usage of
internal HDFS APIs in HBase
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13141929#comment-13141929 ]
Hudson commented on HBASE-4510:
-------------------------------
Integrated in HBase-TRUNK #2398 (See [https://builds.apache.org/job/HBase-TRUNK/2398/])
HBASE-4708 Revert safemode related pieces of hbase-4510
> Check and workaround usage of internal HDFS APIs in HBase
> ---------------------------------------------------------
>
> Key: HBASE-4510
> URL: https://issues.apache.org/jira/browse/HBASE-4510
> Project: HBase
> Issue Type: Task
> Affects Versions: 0.94.0
> Reporter: Harsh J
> Assignee: Harsh J
> Fix For: 0.92.0
>
> Attachments: HBASE-4510.patch
>
>
> HBase isn't seemingly compiling anymore on 0.23 after the HDFS-1620 naming refactorings were carried out.
> Two solutions:
> * We use new classnames. This breaks HBase's backward compatibility with older Hadoop releases (is that a concern with future releases?)
> * HBase gets its own sets of constants as the upstream one is not marked for public usage. This needs a little more maintenance on HBases' side.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4510) HDFS-1620 related changes
downstream (For compiling with HDFS 0.23+)
Posted by "Harsh J (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13117021#comment-13117021 ]
Harsh J commented on HBASE-4510:
--------------------------------
Since this may require a lot of review+discussion, I've opened https://reviews.apache.org/r/2108/
> HDFS-1620 related changes downstream (For compiling with HDFS 0.23+)
> --------------------------------------------------------------------
>
> Key: HBASE-4510
> URL: https://issues.apache.org/jira/browse/HBASE-4510
> Project: HBase
> Issue Type: Task
> Affects Versions: 0.94.0
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Blocker
>
> HBase isn't seemingly compiling anymore on 0.23 after the HDFS-1620 naming refactorings were carried out.
> Two solutions:
> * We use new classnames. This breaks HBase's backward compatibility with older Hadoop releases (is that a concern with future releases?)
> * HBase gets its own sets of constants as the upstream one is not marked for public usage. This needs a little more maintenance on HBases' side.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4510) HDFS-1620 related changes
downstream (For compiling with HDFS 0.23+)
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13129466#comment-13129466 ]
jiraposter@reviews.apache.org commented on HBASE-4510:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2108/
-----------------------------------------------------------
(Updated 2011-10-18 04:01:36.605193)
Review request for hbase.
Changes
-------
Fix Ted's comments.
Commenting further on JIRA itself, since this isn't as urgent as before.
Summary
-------
HBase isn't seemingly compiling anymore on 0.23 after the HDFS-1620 naming refactorings were carried out.
Two solutions:
1. We use new classnames. This breaks HBase's backward compatibility with older Hadoop releases (is that a concern with future releases?)
2. HBase gets its own sets of constants as the upstream one is not marked for public usage. This needs a little more maintenance on HBases' side.
Way (2) seems more viable. I've attached an initial patch that doesn't fix all trouble yet, but introduces the first way of changes.
The remaining issue lies in the use of DistributedFileSystem's safemode methods (which are private audience as well) inside of HBase for safemode waits and checks (via HBases' FSUtils class). Since this uses an enum, it is more difficult to handle without upstream interventions - thoughts?
This addresses bug HBASE-4510.
https://issues.apache.org/jira/browse/HBASE-4510
Diffs (updated)
-----
src/main/java/org/apache/hadoop/hbase/util/FSHDFSUtils.java dcd0937
src/main/java/org/apache/hadoop/hbase/util/FSUtils.java 789dd3b
Diff: https://reviews.apache.org/r/2108/diff
Testing
-------
Thanks,
Harsh
> HDFS-1620 related changes downstream (For compiling with HDFS 0.23+)
> --------------------------------------------------------------------
>
> Key: HBASE-4510
> URL: https://issues.apache.org/jira/browse/HBASE-4510
> Project: HBase
> Issue Type: Task
> Affects Versions: 0.94.0
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Blocker
>
> HBase isn't seemingly compiling anymore on 0.23 after the HDFS-1620 naming refactorings were carried out.
> Two solutions:
> * We use new classnames. This breaks HBase's backward compatibility with older Hadoop releases (is that a concern with future releases?)
> * HBase gets its own sets of constants as the upstream one is not marked for public usage. This needs a little more maintenance on HBases' side.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4510) Check and workaround usage of
internal HDFS APIs in HBase
Posted by "Harsh J (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Harsh J updated HBASE-4510:
---------------------------
Attachment: HBASE-4510.patch
Attaching the +1'd patch.
> Check and workaround usage of internal HDFS APIs in HBase
> ---------------------------------------------------------
>
> Key: HBASE-4510
> URL: https://issues.apache.org/jira/browse/HBASE-4510
> Project: HBase
> Issue Type: Task
> Affects Versions: 0.94.0
> Reporter: Harsh J
> Assignee: Harsh J
> Attachments: HBASE-4510.patch
>
>
> HBase isn't seemingly compiling anymore on 0.23 after the HDFS-1620 naming refactorings were carried out.
> Two solutions:
> * We use new classnames. This breaks HBase's backward compatibility with older Hadoop releases (is that a concern with future releases?)
> * HBase gets its own sets of constants as the upstream one is not marked for public usage. This needs a little more maintenance on HBases' side.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4510) HDFS-1620 related changes
downstream (For compiling with HDFS 0.23+)
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13117015#comment-13117015 ]
stack commented on HBASE-4510:
------------------------------
Ugh. Thanks Harsh for opening this issue. Would be nice if 0.92 was working w/ current state of 0.23 branch at time of release.
> HDFS-1620 related changes downstream (For compiling with HDFS 0.23+)
> --------------------------------------------------------------------
>
> Key: HBASE-4510
> URL: https://issues.apache.org/jira/browse/HBASE-4510
> Project: HBase
> Issue Type: Task
> Affects Versions: 0.94.0
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Blocker
>
> HBase isn't seemingly compiling anymore on 0.23 after the HDFS-1620 naming refactorings were carried out.
> Two solutions:
> * We use new classnames. This breaks HBase's backward compatibility with older Hadoop releases (is that a concern with future releases?)
> * HBase gets its own sets of constants as the upstream one is not marked for public usage. This needs a little more maintenance on HBases' side.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HBASE-4510) Check and workaround usage of
internal HDFS APIs in HBase
Posted by "stack (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack resolved HBASE-4510.
--------------------------
Resolution: Fixed
Fix Version/s: 0.92.0
Hadoop Flags: Reviewed
Applied to 0.92 branch and TRUNK. Thanks Harsh.
> Check and workaround usage of internal HDFS APIs in HBase
> ---------------------------------------------------------
>
> Key: HBASE-4510
> URL: https://issues.apache.org/jira/browse/HBASE-4510
> Project: HBase
> Issue Type: Task
> Affects Versions: 0.94.0
> Reporter: Harsh J
> Assignee: Harsh J
> Fix For: 0.92.0
>
> Attachments: HBASE-4510.patch
>
>
> HBase isn't seemingly compiling anymore on 0.23 after the HDFS-1620 naming refactorings were carried out.
> Two solutions:
> * We use new classnames. This breaks HBase's backward compatibility with older Hadoop releases (is that a concern with future releases?)
> * HBase gets its own sets of constants as the upstream one is not marked for public usage. This needs a little more maintenance on HBases' side.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4510) Check and workaround usage of
internal HDFS APIs in HBase
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13132116#comment-13132116 ]
Hudson commented on HBASE-4510:
-------------------------------
Integrated in HBase-TRUNK #2346 (See [https://builds.apache.org/job/HBase-TRUNK/2346/])
HBASE-4510 Check and workaround usage of internal HDFS APIs in HBase
stack :
Files :
* /hbase/trunk/CHANGES.txt
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/util/FSHDFSUtils.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/util/FSUtils.java
> Check and workaround usage of internal HDFS APIs in HBase
> ---------------------------------------------------------
>
> Key: HBASE-4510
> URL: https://issues.apache.org/jira/browse/HBASE-4510
> Project: HBase
> Issue Type: Task
> Affects Versions: 0.94.0
> Reporter: Harsh J
> Assignee: Harsh J
> Fix For: 0.92.0
>
> Attachments: HBASE-4510.patch
>
>
> HBase isn't seemingly compiling anymore on 0.23 after the HDFS-1620 naming refactorings were carried out.
> Two solutions:
> * We use new classnames. This breaks HBase's backward compatibility with older Hadoop releases (is that a concern with future releases?)
> * HBase gets its own sets of constants as the upstream one is not marked for public usage. This needs a little more maintenance on HBases' side.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4510) HDFS-1620 related changes
downstream (For compiling with HDFS 0.23+)
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13117022#comment-13117022 ]
jiraposter@reviews.apache.org commented on HBASE-4510:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2108/
-----------------------------------------------------------
Review request for hbase.
Summary
-------
HBase isn't seemingly compiling anymore on 0.23 after the HDFS-1620 naming refactorings were carried out.
Two solutions:
1. We use new classnames. This breaks HBase's backward compatibility with older Hadoop releases (is that a concern with future releases?)
2. HBase gets its own sets of constants as the upstream one is not marked for public usage. This needs a little more maintenance on HBases' side.
Way (2) seems more viable. I've attached an initial patch that doesn't fix all trouble yet, but introduces the first way of changes.
The remaining issue lies in the use of DistributedFileSystem's safemode methods (which are private audience as well) inside of HBase for safemode waits and checks (via HBases' FSUtils class). Since this uses an enum, it is more difficult to handle without upstream interventions - thoughts?
This addresses bug HBASE-4510.
https://issues.apache.org/jira/browse/HBASE-4510
Diffs
-----
src/main/java/org/apache/hadoop/hbase/util/FSHDFSUtils.java dcd0937
Diff: https://reviews.apache.org/r/2108/diff
Testing
-------
Thanks,
Harsh
> HDFS-1620 related changes downstream (For compiling with HDFS 0.23+)
> --------------------------------------------------------------------
>
> Key: HBASE-4510
> URL: https://issues.apache.org/jira/browse/HBASE-4510
> Project: HBase
> Issue Type: Task
> Affects Versions: 0.94.0
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Blocker
>
> HBase isn't seemingly compiling anymore on 0.23 after the HDFS-1620 naming refactorings were carried out.
> Two solutions:
> * We use new classnames. This breaks HBase's backward compatibility with older Hadoop releases (is that a concern with future releases?)
> * HBase gets its own sets of constants as the upstream one is not marked for public usage. This needs a little more maintenance on HBases' side.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4510) Check and workaround usage of
internal HDFS APIs in HBase
Posted by "Ted Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13129475#comment-13129475 ]
Ted Yu commented on HBASE-4510:
-------------------------------
+1 on latest patch.
> Check and workaround usage of internal HDFS APIs in HBase
> ---------------------------------------------------------
>
> Key: HBASE-4510
> URL: https://issues.apache.org/jira/browse/HBASE-4510
> Project: HBase
> Issue Type: Task
> Affects Versions: 0.94.0
> Reporter: Harsh J
> Assignee: Harsh J
>
> HBase isn't seemingly compiling anymore on 0.23 after the HDFS-1620 naming refactorings were carried out.
> Two solutions:
> * We use new classnames. This breaks HBase's backward compatibility with older Hadoop releases (is that a concern with future releases?)
> * HBase gets its own sets of constants as the upstream one is not marked for public usage. This needs a little more maintenance on HBases' side.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HBASE-4510) HDFS-1620 related changes downstream
(For compiling with HDFS 0.23+)
Posted by "Harsh J (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Harsh J reassigned HBASE-4510:
------------------------------
Assignee: Harsh J
> HDFS-1620 related changes downstream (For compiling with HDFS 0.23+)
> --------------------------------------------------------------------
>
> Key: HBASE-4510
> URL: https://issues.apache.org/jira/browse/HBASE-4510
> Project: HBase
> Issue Type: Task
> Affects Versions: 0.94.0
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Blocker
>
> HBase isn't seemingly compiling anymore on 0.23 after the HDFS-1620 naming refactorings were carried out.
> Two solutions:
> * We use new classnames. This breaks HBase's backward compatibility with older Hadoop releases (is that a concern with future releases?)
> * HBase gets its own sets of constants as the upstream one is not marked for public usage. This needs a little more maintenance on HBases' side.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4510) Check and workaround usage of
internal HDFS APIs in HBase
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13141866#comment-13141866 ]
Hudson commented on HBASE-4510:
-------------------------------
Integrated in HBase-0.92 #96 (See [https://builds.apache.org/job/HBase-0.92/96/])
HBASE-4708 Revert safemode related pieces of hbase-4510
> Check and workaround usage of internal HDFS APIs in HBase
> ---------------------------------------------------------
>
> Key: HBASE-4510
> URL: https://issues.apache.org/jira/browse/HBASE-4510
> Project: HBase
> Issue Type: Task
> Affects Versions: 0.94.0
> Reporter: Harsh J
> Assignee: Harsh J
> Fix For: 0.92.0
>
> Attachments: HBASE-4510.patch
>
>
> HBase isn't seemingly compiling anymore on 0.23 after the HDFS-1620 naming refactorings were carried out.
> Two solutions:
> * We use new classnames. This breaks HBase's backward compatibility with older Hadoop releases (is that a concern with future releases?)
> * HBase gets its own sets of constants as the upstream one is not marked for public usage. This needs a little more maintenance on HBases' side.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4510) HDFS-1620 related changes
downstream (For compiling with HDFS 0.23+)
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13129458#comment-13129458 ]
jiraposter@reviews.apache.org commented on HBASE-4510:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2108/
-----------------------------------------------------------
(Updated 2011-10-18 03:42:06.955026)
Review request for hbase.
Changes
-------
Updated patch that should fix 0.23 builds.
Summary
-------
HBase isn't seemingly compiling anymore on 0.23 after the HDFS-1620 naming refactorings were carried out.
Two solutions:
1. We use new classnames. This breaks HBase's backward compatibility with older Hadoop releases (is that a concern with future releases?)
2. HBase gets its own sets of constants as the upstream one is not marked for public usage. This needs a little more maintenance on HBases' side.
Way (2) seems more viable. I've attached an initial patch that doesn't fix all trouble yet, but introduces the first way of changes.
The remaining issue lies in the use of DistributedFileSystem's safemode methods (which are private audience as well) inside of HBase for safemode waits and checks (via HBases' FSUtils class). Since this uses an enum, it is more difficult to handle without upstream interventions - thoughts?
This addresses bug HBASE-4510.
https://issues.apache.org/jira/browse/HBASE-4510
Diffs (updated)
-----
src/main/java/org/apache/hadoop/hbase/util/FSHDFSUtils.java dcd0937
src/main/java/org/apache/hadoop/hbase/util/FSUtils.java 789dd3b
Diff: https://reviews.apache.org/r/2108/diff
Testing
-------
Thanks,
Harsh
> HDFS-1620 related changes downstream (For compiling with HDFS 0.23+)
> --------------------------------------------------------------------
>
> Key: HBASE-4510
> URL: https://issues.apache.org/jira/browse/HBASE-4510
> Project: HBase
> Issue Type: Task
> Affects Versions: 0.94.0
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Blocker
>
> HBase isn't seemingly compiling anymore on 0.23 after the HDFS-1620 naming refactorings were carried out.
> Two solutions:
> * We use new classnames. This breaks HBase's backward compatibility with older Hadoop releases (is that a concern with future releases?)
> * HBase gets its own sets of constants as the upstream one is not marked for public usage. This needs a little more maintenance on HBases' side.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4510) HDFS-1620 related changes
downstream (For compiling with HDFS 0.23+)
Posted by "Ted Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13117025#comment-13117025 ]
Ted Yu commented on HBASE-4510:
-------------------------------
I think the above diff is in the right direction.
> HDFS-1620 related changes downstream (For compiling with HDFS 0.23+)
> --------------------------------------------------------------------
>
> Key: HBASE-4510
> URL: https://issues.apache.org/jira/browse/HBASE-4510
> Project: HBase
> Issue Type: Task
> Affects Versions: 0.94.0
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Blocker
>
> HBase isn't seemingly compiling anymore on 0.23 after the HDFS-1620 naming refactorings were carried out.
> Two solutions:
> * We use new classnames. This breaks HBase's backward compatibility with older Hadoop releases (is that a concern with future releases?)
> * HBase gets its own sets of constants as the upstream one is not marked for public usage. This needs a little more maintenance on HBases' side.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4510) Check and workaround usage of
internal HDFS APIs in HBase
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13132570#comment-13132570 ]
Hudson commented on HBASE-4510:
-------------------------------
Integrated in HBase-0.92 #75 (See [https://builds.apache.org/job/HBase-0.92/75/])
HBASE-4510 Check and workaround usage of internal HDFS APIs in HBase
stack :
Files :
* /hbase/branches/0.92/CHANGES.txt
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/util/FSHDFSUtils.java
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/util/FSUtils.java
> Check and workaround usage of internal HDFS APIs in HBase
> ---------------------------------------------------------
>
> Key: HBASE-4510
> URL: https://issues.apache.org/jira/browse/HBASE-4510
> Project: HBase
> Issue Type: Task
> Affects Versions: 0.94.0
> Reporter: Harsh J
> Assignee: Harsh J
> Fix For: 0.92.0
>
> Attachments: HBASE-4510.patch
>
>
> HBase isn't seemingly compiling anymore on 0.23 after the HDFS-1620 naming refactorings were carried out.
> Two solutions:
> * We use new classnames. This breaks HBase's backward compatibility with older Hadoop releases (is that a concern with future releases?)
> * HBase gets its own sets of constants as the upstream one is not marked for public usage. This needs a little more maintenance on HBases' side.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4510) HDFS-1620 related changes
downstream (For compiling with HDFS 0.23+)
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13129462#comment-13129462 ]
jiraposter@reviews.apache.org commented on HBASE-4510:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2108/#review2641
-----------------------------------------------------------
Ship it!
src/main/java/org/apache/hadoop/hbase/util/FSUtils.java
<https://reviews.apache.org/r/2108/#comment5946>
Typo: retrieved
src/main/java/org/apache/hadoop/hbase/util/FSUtils.java
<https://reviews.apache.org/r/2108/#comment5947>
This condition is covered by isInSafeMode() already.
- Ted
On 2011-10-18 03:42:06, Harsh J wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2108/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-10-18 03:42:06)
bq.
bq.
bq. Review request for hbase.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. HBase isn't seemingly compiling anymore on 0.23 after the HDFS-1620 naming refactorings were carried out.
bq.
bq. Two solutions:
bq.
bq. 1. We use new classnames. This breaks HBase's backward compatibility with older Hadoop releases (is that a concern with future releases?)
bq. 2. HBase gets its own sets of constants as the upstream one is not marked for public usage. This needs a little more maintenance on HBases' side.
bq.
bq. Way (2) seems more viable. I've attached an initial patch that doesn't fix all trouble yet, but introduces the first way of changes.
bq.
bq. The remaining issue lies in the use of DistributedFileSystem's safemode methods (which are private audience as well) inside of HBase for safemode waits and checks (via HBases' FSUtils class). Since this uses an enum, it is more difficult to handle without upstream interventions - thoughts?
bq.
bq.
bq. This addresses bug HBASE-4510.
bq. https://issues.apache.org/jira/browse/HBASE-4510
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/java/org/apache/hadoop/hbase/util/FSHDFSUtils.java dcd0937
bq. src/main/java/org/apache/hadoop/hbase/util/FSUtils.java 789dd3b
bq.
bq. Diff: https://reviews.apache.org/r/2108/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Harsh
bq.
bq.
> HDFS-1620 related changes downstream (For compiling with HDFS 0.23+)
> --------------------------------------------------------------------
>
> Key: HBASE-4510
> URL: https://issues.apache.org/jira/browse/HBASE-4510
> Project: HBase
> Issue Type: Task
> Affects Versions: 0.94.0
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Blocker
>
> HBase isn't seemingly compiling anymore on 0.23 after the HDFS-1620 naming refactorings were carried out.
> Two solutions:
> * We use new classnames. This breaks HBase's backward compatibility with older Hadoop releases (is that a concern with future releases?)
> * HBase gets its own sets of constants as the upstream one is not marked for public usage. This needs a little more maintenance on HBases' side.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4510) HDFS-1620 related changes
downstream (For compiling with HDFS 0.23+)
Posted by "Ted Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13117013#comment-13117013 ]
Ted Yu commented on HBASE-4510:
-------------------------------
I think option 2 is more viable.
We should keep backward compatibility.
> HDFS-1620 related changes downstream (For compiling with HDFS 0.23+)
> --------------------------------------------------------------------
>
> Key: HBASE-4510
> URL: https://issues.apache.org/jira/browse/HBASE-4510
> Project: HBase
> Issue Type: Task
> Affects Versions: 0.94.0
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Blocker
>
> HBase isn't seemingly compiling anymore on 0.23 after the HDFS-1620 naming refactorings were carried out.
> Two solutions:
> * We use new classnames. This breaks HBase's backward compatibility with older Hadoop releases (is that a concern with future releases?)
> * HBase gets its own sets of constants as the upstream one is not marked for public usage. This needs a little more maintenance on HBases' side.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4510) Check and workaround usage of
internal HDFS APIs in HBase
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13131907#comment-13131907 ]
jiraposter@reviews.apache.org commented on HBASE-4510:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2108/#review2717
-----------------------------------------------------------
Ship it!
- Michael
On 2011-10-18 04:01:36, Harsh J wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2108/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-10-18 04:01:36)
bq.
bq.
bq. Review request for hbase.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. HBase isn't seemingly compiling anymore on 0.23 after the HDFS-1620 naming refactorings were carried out.
bq.
bq. Two solutions:
bq.
bq. 1. We use new classnames. This breaks HBase's backward compatibility with older Hadoop releases (is that a concern with future releases?)
bq. 2. HBase gets its own sets of constants as the upstream one is not marked for public usage. This needs a little more maintenance on HBases' side.
bq.
bq. Way (2) seems more viable. I've attached an initial patch that doesn't fix all trouble yet, but introduces the first way of changes.
bq.
bq. The remaining issue lies in the use of DistributedFileSystem's safemode methods (which are private audience as well) inside of HBase for safemode waits and checks (via HBases' FSUtils class). Since this uses an enum, it is more difficult to handle without upstream interventions - thoughts?
bq.
bq.
bq. This addresses bug HBASE-4510.
bq. https://issues.apache.org/jira/browse/HBASE-4510
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/java/org/apache/hadoop/hbase/util/FSHDFSUtils.java dcd0937
bq. src/main/java/org/apache/hadoop/hbase/util/FSUtils.java 789dd3b
bq.
bq. Diff: https://reviews.apache.org/r/2108/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Harsh
bq.
bq.
> Check and workaround usage of internal HDFS APIs in HBase
> ---------------------------------------------------------
>
> Key: HBASE-4510
> URL: https://issues.apache.org/jira/browse/HBASE-4510
> Project: HBase
> Issue Type: Task
> Affects Versions: 0.94.0
> Reporter: Harsh J
> Assignee: Harsh J
> Attachments: HBASE-4510.patch
>
>
> HBase isn't seemingly compiling anymore on 0.23 after the HDFS-1620 naming refactorings were carried out.
> Two solutions:
> * We use new classnames. This breaks HBase's backward compatibility with older Hadoop releases (is that a concern with future releases?)
> * HBase gets its own sets of constants as the upstream one is not marked for public usage. This needs a little more maintenance on HBases' side.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira